Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E0089 to new error format #36103

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Update E0089 to new error format #36103

merged 1 commit into from
Aug 30, 2016

Conversation

swr1bm86
Copy link
Contributor

Fixes #35227.
Part of #35233.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@swr1bm86 swr1bm86 changed the title Update E0089 to new error format [WIP] Update E0089 to new error format Aug 29, 2016
@sophiajt
Copy link
Contributor

@zjhmale - looks good so far. Are you still working on this?

@swr1bm86 swr1bm86 changed the title [WIP] Update E0089 to new error format Update E0089 to new error format Aug 29, 2016
@swr1bm86
Copy link
Contributor Author

@jonathandturner just update it, please review 😄

@sophiajt
Copy link
Contributor

Great :)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 29, 2016

📌 Commit 01083ba has been approved by jonathandturner

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 29, 2016
@GuillaumeGomez
Rollup merge of rust-lang#36103 - zjhmale:fix-E0089, r=jonathandturner
0ff8a6a 
Update E0089 to new error format

Fixes rust-lang#35227.
Part of rust-lang#35233.

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge of rust-lang#36103 - zjhmale:fix-E0089, r=jonathandturner
21e2155 
Update E0089 to new error format

Fixes rust-lang#35227.
Part of rust-lang#35233.

r? @jonathandturner
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 30, 2016
Merged
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of #36126 - GuillaumeGomez:rollup, r=GuillaumeGomez
badf406 
Rollup of 16 pull requests

- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge of rust-lang#36103 - zjhmale:fix-E0089, r=jonathandturner
9a3cfe9 
Update E0089 to new error format

Fixes rust-lang#35227.
Part of rust-lang#35233.

r? @jonathandturner
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of #36126 - GuillaumeGomez:rollup, r=GuillaumeGomez
4473130 
Rollup of 16 pull requests

- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
@bors bors merged commit 01083ba into rust-lang:master Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swr1bm86 @rust-highfive @sophiajt @bors