-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nightly docs supported Windows versions to match Getting Started page #36225
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ rollup thanks! /cc @carols10cents |
📌 Commit eb1c716 has been approved by |
…eklabnik Update nightly docs supported Windows versions to match Getting Started page https://doc.rust-lang.org/book/getting-started.html#tier-1 shows that Windows 7+ is officially supported (implying, for example Windows 10), but the nightly page only listed 7, 8, and Server 2008 R2).
…eklabnik Update nightly docs supported Windows versions to match Getting Started page https://doc.rust-lang.org/book/getting-started.html#tier-1 shows that Windows 7+ is officially supported (implying, for example Windows 10), but the nightly page only listed 7, 8, and Server 2008 R2).
@Manishearth Curious as to why it looks like this fix is still not showing up in the latest docs: https://doc.rust-lang.org/book/nightly-rust.html#uninstalling |
@johnthagen that's the stable docs link, see https://doc.rust-lang.org/nightly/book/nightly-rust.html#uninstalling (that is, this change hasn't hit stable yet) |
Thanks for the explanation @steveklabnik, appreciate it. I didn't realized the docs also operated under the same nightly/release cycles, but now that I think about it, that makes a lot of sense. |
Yup! They're included as part of the installation, so they're just as much a part of the release as anything else 😄 |
https://doc.rust-lang.org/book/getting-started.html#tier-1 shows that Windows 7+ is officially supported (implying, for example Windows 10), but the nightly page only listed 7, 8, and Server 2008 R2.