rustbuild: add config.toml option to disable codegen tests #36234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durka
force-pushed
the
disable-codegen-config
branch
from
6fd0c45
to
20a2f87
Compare
| @@ -129,6 +129,7 @@ | |||
| # with debuginfo (the -g flag) | |||
| #optimize-tests = true | |||
| #debuginfo-tests = true | |||
| #codegen-tests = true | |||
There was a problem hiding this comment.
This is actually slightly different from the above config because it disables tests rather than configure how they're compiled. Perhaps this could have its own doc block explaining it?
There was a problem hiding this comment.
Oops, I didn't even read the doc block, was just following the pattern.
durka
force-pushed
the
disable-codegen-config
branch
from
20a2f87
to
0efc4bf
Compare
|
@bors: r+ |
|
📌 Commit 0efc4bf has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 4, 2016
…xcrichton rustbuild: add config.toml option to disable codegen tests Fixes rust-lang#36232. I think it worked? Here's a build log where I tried to bootstrap, it crashed, then I added the setting to config.toml and it continued: https://gist.github.com/durka/cbf97cf04b8e065f1a2cfda4c1b6bf95 r? @alexcrichton
bors
added a commit
that referenced
this pull request
Sep 4, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 4, 2016
…xcrichton rustbuild: add config.toml option to disable codegen tests Fixes rust-lang#36232. I think it worked? Here's a build log where I tried to bootstrap, it crashed, then I added the setting to config.toml and it continued: https://gist.github.com/durka/cbf97cf04b8e065f1a2cfda4c1b6bf95 r? @alexcrichton
bors
added a commit
that referenced
this pull request
Sep 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36232.
I think it worked? Here's a build log where I tried to bootstrap, it crashed, then I added the setting to config.toml and it continued: https://gist.github.com/durka/cbf97cf04b8e065f1a2cfda4c1b6bf95
r? @alexcrichton