Fix ICE test in compiletest fail-tests

[mcarton]

While working on Clippy which uses compiletest, I noticed that as long as all expected error are found, compile-fail tests will be marked ok even if there is an ICE. One function seems to have not been updated with JSON errors because ICEs are now reported like this:

{"message":"../src/librustc/ty/context.rs:161: Attempted to intern `_` which contains inference types/regions in the global type context","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":null}

I don't think I can add a test for that.

I guess:
r? @nikomatsakis

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[nikomatsakis]

@bors r+ rollup

[bors]

📌 Commit dd6e386 has been approved by nikomatsakis

[nikomatsakis]

@mcarton good catch =)

[bors]

⌛ Testing commit dd6e386 with merge 5df533b...

[bors]

💔 Test failed - auto-win-gnu-32-opt-rustbuild

[alexcrichton]

@bors: retry

On Tue, Sep 13, 2016 at 8:30 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/2501

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36335 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Bx6QXitYEUbFtdUzNNAlFgtWAspks5qp2pHgaJpZM4J3dOj
.

[GuillaumeGomez]

It made an ICE it seems: https://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/10480/steps/test/logs/stdio

[GuillaumeGomez]

@bors: rollup-

[mcarton]

% rustc src/test/compile-fail/issue-31109.rs
error: internal compiler error: ../src/librustc_const_eval/eval.rs:1273: could not evaluate float literal (see issue #31407)
  --> src/test/compile-fail/issue-31109.rs:14:18
   |
14 |     let _: f64 = 1234567890123456789012345678901234567890e-340; //~ ERROR could not evaluate float
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

note: the compiler unexpectedly panicked. this is a bug.

Looks weird to check for the presence of an ICE.
Should that be converted to a regular error?

[nikomatsakis]

It sounds to me like the desired error is being reported and then,
separately, an ICE. In other words the PR is catching a latent bug.

On Sep 14, 2016 12:27 PM, "Martin Carton" notifications@github.com wrote:

% rustc src/test/compile-fail/issue-31109.rs
error: internal compiler error: ../src/librustc_const_eval/eval.rs:1273: could not evaluate float literal (see issue #31407)
--> src/test/compile-fail/issue-31109.rs:14:18
|
14 | let _: f64 = 1234567890123456789012345678901234567890e-340; //~ ERROR could not evaluate float
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

note: the compiler unexpectedly panicked. this is a bug.

Looks weird to check for the presence of an ICE.
Should that be converted to a regular error?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#36335 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJeZverDK_qEjte5yhiQBt7ms8pVIE6ks5qqCCDgaJpZM4J3dOj
.

[bors]

⌛ Testing commit dd6e386 with merge a0473dc...

[bors]

💔 Test failed - auto-mac-32-opt

[mcarton]

I've changed the error so that it does not ICE anymore.

[GuillaumeGomez]

But it still fails travis. :p

[mcarton]

This once, I've tested it 😅

[GuillaumeGomez]

And travis seems happy. All good for me then. Thanks!

@bors: r+ rollup

[bors]

📌 Commit bfa3433 has been approved by GuillaumeGomez

[bors]

⌛ Testing commit bfa3433 with merge 86a686c...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: GuillaumeGomez
Pushing 86a686c to master...

[hanna-kruppe]

I only now saw this PR. When I introduced that test in #31410 I was told to make it a span_bug rather than an ordinary error. So it's not a latent bug, it was an "intentional ICE". Maybe whoever has the last word on that decides that ICE-ing on known issues isn't good, but I do want to bring it up just to be sure.