Rollup of 5 pull requests #36472
Merged
Rollup of 5 pull requests #36472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Sep 14, 2016
GuillaumeGomez
commented
- Successful merges: Set run button transparent instead of invisible #36334, Fix ICE test in compiletest fail-tests #36335, Add urls #36363, book: fix mistake (File::open -> File::create) #36374, Add doc examples for std::net::IpAddr construction. #36467
- Failed merges:
|
@bors: r+ p=1 |
|
📌 Commit 4c84d3b has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 4c84d3b with merge 22a5222... |
|
💔 Test failed - auto-linux-64-opt |
GuillaumeGomez
force-pushed
the
rollup
branch
from
4c84d3b
to
739d571
Compare
Set run button transparent instead of invisible r? @steveklabnik And of course a screenshot: 
…bnik Add urls r? @steveklabnik
book: fix mistake (File::open -> File::create)
Documentation of what Default does for each type Addresses rust-lang#36265 I haven't changed the following types due to doubts: 1)src/libstd/ffi/c_str.rs 2)src/libcore/iter/sources.rs 3)src/libcore/hash/mod.rs 4)src/libcore/hash/mod.rs 5)src/librustc/middle/privacy.rs r? @steveklabnik
Add doc examples for std::net::IpAddr construction. None
|
@bors: r+ p=1 |
|
📌 Commit e368cdd has been approved by |
This was referenced Sep 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.