add default docstrings for String and AtomicBool
#36364
Conversation
|
Relevant pull request, not sure if it's relevant anymore though #23271 . I'm still personally in favor of being explicit about what the |
|
@frewsxcv Oops, didn't see that, thank you. Also, the reason my |
|
I think this can stay open. #23271 didn't merge, and I don't have any intention to reopen it. |
|
@frewsxcv Okay, sounds good. I would have done this differently had I known what I do now, but it looks like these changes still constitute an improvement. |
| fn default() -> Generics { | ||
| /// Create a empty `Generics` with no lifetimes, type parameters, | ||
| /// where-clause, or span. | ||
| fn default() -> Generics { |
There was a problem hiding this comment.
I don't think this is useful to write an explanation for an inner type.
matthew-piziak
force-pushed
the
default-docs
branch
2 times, most recently
from
de1550d to
cec3335
Compare
matthew-piziak
changed the title
default docstrings for String, AtomicBool, and Genericsdefault docstrings for String and AtomicBool
Part of rust-lang#36265. These are all the instances of `Default` in this repository that are of the form `impl Default for X`. The default for `i32`, for example, is not of this form. @GuillaumeGomez
matthew-piziak
force-pushed
the
default-docs
branch
from
cec3335 to
a390564
Compare
|
☔ The latest upstream changes (presumably #36472) made this pull request unmergeable. Please resolve the merge conflicts. |
|
It seems it has already been done. |
Part of #36265.
These are all the instances of
Defaultin this repository that are of the formimpl Default for X. The default fori32, for example, is not of this form.r? @GuillaumeGomez