Skip to content

Clarify Index/IndexMut trait docs #36529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2016
Merged

Clarify Index/IndexMut trait docs #36529

merged 1 commit into from
Sep 30, 2016

Conversation

bluss
Copy link
Member

@bluss bluss commented Sep 16, 2016

Use examples and placeholder variable names with more meaning, to not
make it so abstract.

Use examples and placeholder variable names with more meaning, to not
make it so abstract.
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@bluss
Copy link
Member Author

bluss commented Sep 16, 2016

I was a bit annoyed my own docs included the upstream doc for index_mut like this: "The method for the indexing (Foo[Bar]) operation". I prefer to use placeholders with meaning ("index").

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 29, 2016

📌 Commit fe62b41 has been approved by GuillaumeGomez

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Sep 30, 2016
Clarify Index/IndexMut trait docs

Use examples and placeholder variable names with more meaning, to not
make it so abstract.
bors added a commit that referenced this pull request Sep 30, 2016
Rollup of 13 pull requests

- Successful merges: #36529, #36535, #36576, #36623, #36711, #36750, #36810, #36829, #36833, #36841, #36842, #36851, #36860
- Failed merges:
@bors bors merged commit fe62b41 into rust-lang:master Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants