Suggesting a change to a comment that puzzled me #36711
Conversation
While reading this, the comment made it difficult for me to simply absorb the concept. It interrupted my reading flow, and I think this expresses the same meaning, but reads a bit better.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -86,7 +86,7 @@ fn main() { | |||
| return v.iter().fold(0, |a, &b| a + b); | |||
| } | |||
| // Borrow two vectors and sum them. | |||
| // This kind of borrowing does not allow mutation to the borrowed. | |||
| // This kind of borrowing does not allow mutation to the borrowed reference. | |||
There was a problem hiding this comment.
"the borrowed" refers to the vector (or vectors), not to the reference. What could be said is "does not allow mutation through the borrowed reference".
There was a problem hiding this comment.
Or just "does not allow mutation of the borrowed vectors." (?)
There was a problem hiding this comment.
I like "through" I think it helps me understand better.
|
@bors: r+ rollup thanks! |
|
📌 Commit c30eb31 has been approved by |
Suggesting a change to a comment that puzzled me While reading this, the comment made it difficult for me to simply absorb the concept. It interrupted my reading flow, and I think this expresses the same meaning, but reads a bit better. It's trivial, but makes it easier for me to move on to the next line.
While reading this, the comment made it difficult for me to simply absorb the concept. It interrupted my reading flow, and I think this expresses the same meaning, but reads a bit better. It's trivial, but makes it easier for me to move on to the next line.