parser: support paths in bang macro invocations (e.g. path::to::macro!())
#36662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
commented
Sep 22, 2016
| } | ||
|
|
||
| m!(); //~ NOTE the usage of `m!` is likely invalid in item context | ||
|
|
There was a problem hiding this comment.
After this PR, this would trigger a parse error when expanded (expected one of !or::``).
jseyfried
force-pushed
the
parse_macro_invoc_paths
branch
2 times, most recently
from
9b1c954 to
be28b20
Compare
jseyfried
force-pushed
the
parse_macro_invoc_paths
branch
from
be28b20 to
2c85733
Compare
|
Looks good. Note to myself: audit all places where disambiguation "path vs ident" happens, there are still some inconsistencies. |
|
Am I right that this PR means path macros can be parsed but will always give an error later on before being expanded? If not, then it'd be good to have a feature gate in here. Could you add some tests too please? |
|
Yeah, |
|
Added tests. |
|
@bors: r+ |
|
📌 Commit 34f4ad1 has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 26, 2016
…r=nrc parser: support paths in bang macro invocations (e.g. `path::to::macro!()`) r? @nrc
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 27, 2016
…r=nrc parser: support paths in bang macro invocations (e.g. `path::to::macro!()`) r? @nrc
bors
added a commit
that referenced
this pull request
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groundwork for macro modularization (cc #35896).
r? @nrc