Rollup of 8 pull requests #36759
Closed
Rollup of 8 pull requests #36759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated paragraphs and wording for clarity. - Renamed `helloworld.rs` to `myprogram.rs` to make it clearer that it's an unrelated example.
This is about the gray area at the top of a trait's documentation page, that lists all methods and their signatures. A big trait page like Iterator is very crowded without this tweak.
This doesn't actually do anything for LLVM 4.x yet, but sets the stage.
Docs: Update to "Getting Started" section I came across rust-lang#34523 and wanted to suggest a solution. See commit for details. It seemed like a good place to start contributing, let me know if I did anything wrong 😇
…r=nrc parser: support paths in bang macro invocations (e.g. `path::to::macro!()`) r? @nrc
Unify `TokResult` and `ResultAnyMacro` Fixes rust-lang#36641. r? @nrc
…bnik rustdoc css: Put `where` in trait listings on a new line This is about the gray area at the top of a trait's documentation page, that lists all methods and their signatures. A big trait page like Iterator is very crowded without this tweak.
reject macros with empty repetitions Fixes rust-lang#5067 by checking the lhs of `macro_rules!` for repetitions which could match an empty token tree.
…rner E0513 Part of rust-lang#35233 r? @jonathandturner
…richton Extend preprocessor LLVM version checks to support LLVM 4.x This doesn't actually do anything for LLVM 4.x yet, but sets the stage.
…dturner New error format for E0512 Part of rust-lang#35233, fixes rust-lang#36107 r? @jonathandturner
|
@bors r+ p=1 |
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit cd3b3e8 has been approved by |
|
Rerolling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path::to::macro!()) #36662, UnifyTokResultandResultAnyMacro#36669, rustdoc css: Putwherein trait listings on a new line #36676, reject macros with empty repetitions #36721, E0513 #36723, Extend preprocessor LLVM version checks to support LLVM 4.x #36742, New error format for E0512 #36756