Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcase about issue-18088 #36783

Merged
merged 1 commit into from
Sep 29, 2016
Merged

testcase about issue-18088 #36783

merged 1 commit into from
Sep 29, 2016

Conversation

ParkHanbum
Copy link
Contributor

@ParkHanbum ParkHanbum commented Sep 27, 2016

this testcase is associated with issue #18088 . you can find that here. #18088.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@TimNN
Copy link
Contributor

TimNN commented Sep 27, 2016

Can you add the license header to the top of the file:

// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

@ParkHanbum
Copy link
Contributor Author

understand. I'll do my best.

@TimNN
Copy link
Contributor

TimNN commented Sep 28, 2016

Awesome, thank you very much!

This looks almost good now, can you squash all those commits down into one and (force) push that? If you need any help with that feel free to ask here or on irc.

@ParkHanbum
Copy link
Contributor Author

ParkHanbum commented Sep 28, 2016

@TimNN Pushed. thanks!

@TimNN
Copy link
Contributor

TimNN commented Sep 28, 2016

This looks good now, thank you!

Someone from the Rust Team with the required privileges will soon review (and likely approve) this PR, afterwards the PR will be queued to be tested and then finally merged.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Sep 28, 2016

📌 Commit b543f3a has been approved by alexcrichton

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 28, 2016
testcase about issue-18088

this testcase is associated with issue rust-lang#18088 . you can find that here. rust-lang#18088.
bors added a commit that referenced this pull request Sep 28, 2016
Rollup of 11 pull requests

- Successful merges: #36376, #36672, #36740, #36757, #36765, #36769, #36782, #36783, #36784, #36795, #36796
- Failed merges:
@bors bors merged commit b543f3a into rust-lang:master Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants