Rollup of 11 pull requests #36805
Merged
Rollup of 11 pull requests #36805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit alters the expansion order of custom macros-1.1 style `#[derive]` modes. Instead of left-to-right the expansion now happens in three categories, each of which is internally left-to-right: * Old-style custom derive (`#[derive_Foo]`) is expanded * New-style custom derive (macros 1.1) is expanded * Built in derive modes are expanded This gives built in derive modes maximal knowledge about the struct that's being expanded and also avoids pesky issues like exposing `#[structural_match]` or `#[rustc_copy_clone_marker]`. cc rust-lang#35900
…rner Update E0050 to new error format Part of rust-lang#35233. Fixes rust-lang#35211. r? @jonathandturner
Improve documention troubleshooting missing linker. Fix rust-lang#32208. @steveklabnik is this in the direction on how you want to see rust-lang#32208 fixed?
Document init of HashSet/HashMap from vector
…urner Update E0025 to new error format Part of rust-lang#35233. Fixes rust-lang#35198. r? @jonathandturner
…abnik Add basic doc example for `core::ptr::write_bytes`. None
doc: Fix minor typo in book/variable-bindings.md r? @steveklabnik
…er, r=nrc rustc: Tweak expansion order of custom derive This commit alters the expansion order of custom macros-1.1 style `#[derive]` modes. Instead of left-to-right the expansion now happens in three categories, each of which is internally left-to-right: * Old-style custom derive (`#[derive_Foo]`) is expanded * New-style custom derive (macros 1.1) is expanded * Built in derive modes are expanded This gives built in derive modes maximal knowledge about the struct that's being expanded and also avoids pesky issues like exposing `#[structural_match]` or `#[rustc_copy_clone_marker]`. cc rust-lang#35900
testcase about issue-18088 this testcase is associated with issue rust-lang#18088 . you can find that here. rust-lang#18088.
…hton Remove requirement to use 10.7 (fixes macOS) Fixes rust-lang#36650 by removing the requirement to use 10.7. @alexcrichton pointed out that the buildbots won't be affected, since they set the requirement with an environment variable. This should now allow rustbuild to build Rust on macOS (nee OS X) r? @alexcrichton
TypeIdHasher: hash usize as u64 Fixes rust-lang#36793.
update mips64* data-layout I tried to compile some (`#![no_core]`) code for the `mips64` targets on the latest nightly and got ICE's about mismatched data layouts. I updated the data layouts to match the listed llvm defaults. cc @japaric Funnily enough, this seems to be the exact reverse of what @japaric did in 2222d43 as part of rust-lang#36024.
|
@bors r+ p=1 |
|
📌 Commit ac82eaa has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core::ptr::write_bytes. #36765, doc: Fix minor typo in book/variable-bindings.md #36769, rustc: Tweak expansion order of custom derive #36782, testcase about issue-18088 #36783, Remove requirement to use 10.7 (fixes macOS) #36784, TypeIdHasher: hash usize as u64 #36795, update mips64* data-layout #36796