Fix importing inaccessible extern crates (with a warning)
#37023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2016
nikomatsakis
added
beta-nominated
|
Nominating for backport because regression. |
|
Fixes #37018 as well. |
|
And also fixes #37021. |
|
Thanks for the quick fixes @jseyfried! |
|
@bors: r+ |
|
📌 Commit 4080efd has been approved by |
nikomatsakis
added
the
beta-accepted
|
Marking as beta-accepted. Short patch, fixes regression. cc @rust-lang/compiler |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Oct 11, 2016
…pat, r=nrc Fix importing inaccessible `extern crate`s (with a warning) Fixes rust-lang#36747, fixes rust-lang#37020, and fixes rust-lang#37021. r? @nrc
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 12, 2016
…pat, r=nrc Fix importing inaccessible `extern crate`s (with a warning) Fixes rust-lang#36747, fixes rust-lang#37020, and fixes rust-lang#37021. r? @nrc
bors
added a commit
that referenced
this pull request
Oct 12, 2016
Merged
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35776 broke importing inaccessible
extern crates, which should work with a warning (c.f. #31362).Fixes #36747, fixes #37020, and fixes #37021.
r? @nrc