-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 17 pull requests #37118
Merged
Merged
Rollup of 17 pull requests #37118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be used to determine the type of the underlying IP address
`opaque::Decoder::read_str` is very hot within `rustc` due to its use in the reading of crate metadata, and it currently returns a `String`. This commit changes it to instead return a `Cow<str>`, which avoids a heap allocation. This change reduces the number of calls to `malloc` by almost 10% in some benchmarks. This is a [breaking-change] to libserialize.
Resolves a FIXME
💔 Test failed - auto-win-msvc-64-cargotest |
Move IdxSetBuf and BitSlice to rustc_data_structures Resolves a FIXME
stabilise ?, attributes on stmts, deprecate Reflect r? @nikomatsakis
…pat, r=nrc Fix importing inaccessible `extern crate`s (with a warning) Fixes rust-lang#36747, fixes rust-lang#37020, and fixes rust-lang#37021. r? @nrc
run rustfmt on librustc_lint folder
librustdoc refactoring and cleanup.
…, r=bluss Add comparison operators to boolean const eval. I think it might be worth adding tests here, but since I don't know how or where to do that, I have not done so yet. Willing to do so if asked and given an explanation as to how. Fixes rust-lang#37047.
Avoid allocations in `Decoder::read_str`. `opaque::Decoder::read_str` is very hot within `rustc` due to its use in the reading of crate metadata, and it currently returns a `String`. This commit changes it to instead return a `Cow<str>`, which avoids a heap allocation. This change reduces the number of calls to `malloc` by almost 10% in some benchmarks. This is a [breaking-change] to libserialize.
Error monitor should emit error to stderr instead of stdout We are pretty consistent about emitting to stderr, except for when there is actually an error, in which case we emit to stdout. This seems a bit backwards. This PR just changes that exception to emit to stderr. This is useful for the RLS since the LS protocol uses stdout (grrr). r? @alexcrichton
…excrichton macros: expand `#[derive]`s after other attribute macros and improve intra-`#[derive]` ordering Fixes serde-rs/serde#577. cc rust-lang#35900 r? @alexcrichton
…e_scopes, r=nrc macros: clean up scopes of expanded `#[macro_use]` imports This PR changes the scope of macro-expanded `#[macro_use]` imports to match that of unexpanded `#[macro_use]` imports. For example, this would be allowed: ```rust example!(); macro_rules! m { () => { #[macro_use(example)] extern crate example_crate; } } m!(); ``` This PR also enforces the full shadowing restrictions from RFC 1560 on `#[macro_use]` imports (currently, we only enforce the weakened restrictions from rust-lang#36767). This is a [breaking-change], but I believe it is highly unlikely to cause breakage in practice. r? @nrc
Add missing urls in io module r? @steveklabnik
configure: Fix gcc detection for LLVM We have a case where 32-bit compilation accidentally requested clang when gcc was the only one available.
std: Update liblibc submodule This fixes compilation on the s390x target
normalize tuple pair types in trans Fixes rust-lang#37109. Note that rust-lang#37109 is a regression from stable to stable, beta and nightly.
@bors: r+ |
📌 Commit 27043b1 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 12, 2016
This was referenced Oct 13, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extern crate
s (with a warning) #37023, run rustfmt on librustc_lint folder #37049, librustdoc refactoring and cleanup. #37050, Add comparison operators to boolean const eval. #37056, Avoid allocations inDecoder::read_str
. #37064, Error monitor should emit error to stderr instead of stdout #37066, macros: expand#[derive]
s after other attribute macros and improve intra-#[derive]
ordering #37067, macros: clean up scopes of expanded#[macro_use]
imports #37084, Add missing urls in io module #37089, configure: Fix gcc detection for LLVM #37091, std: Update liblibc submodule #37092, normalize tuple pair types in trans #37110