Rollup of 24 pull requests #37597
Merged
Rollup of 24 pull requests #37597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example code for higher-ranked trait bounds on closures had an unnecessary `mut` which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed). Removed the `mut`s and fixed the text to better describe the actual error for the failing example.
This commit is an implementation of [RFC 1665] which adds support for the `#![windows_subsystem]` attribute. This attribute allows specifying either the "windows" or "console" subsystems on Windows to the linker. [RFC 1665]: https://github.com/rust-lang/rfcs/blob/master/text/1665-windows-subsystem.md Previously all Rust executables were compiled as the "console" subsystem which meant that if you wanted a graphical application it would erroneously pop up a console whenever opened. When compiling an application, however, this is undesired behavior and the "windows" subsystem is used instead to have control over user interactions. This attribute is validated, but ignored on all non-Windows platforms. cc rust-lang#37499
This commit is a rewrite of the user-facing interface to the rustbuild build
system. The intention here is to make it much easier to compile/test the project
without having to remember weird rule names and such. An overall view of the new
interface is:
# build everything
./x.py build
# document everyting
./x.py doc
# test everything
./x.py test
# test libstd
./x.py test src/libstd
# build libcore stage0
./x.py build src/libcore --stage 0
# run stage1 run-pass tests
./x.py test src/test/run-pass --stage 1
The `src/bootstrap/bootstrap.py` script is now aliased as a top-level `x.py`
script. This `x` was chosen to be both short and easily tab-completable (no
collisions in that namespace!). The build system now accepts a "subcommand" of
what to do next, the main ones being build/doc/test.
Each subcommand then receives an optional list of arguments. These arguments are
paths in the source repo of what to work with. That is, if you want to test a
directory, you just pass that directory as an argument.
The purpose of this rewrite is to do away with all of the arcane renames like
"rpass" is the "run-pass" suite, "cfail" is the "compile-fail" suite, etc. By
simply working with directories and files it's much more intuitive of how to run
a test (just pass it as an argument).
The rustbuild step/dependency management was also rewritten along the way to
make this easy to work with and define, but that's largely just a refactoring of
what was there before.
The *intention* is that this support is extended for arbitrary files (e.g.
`src/test/run-pass/my-test-case.rs`), but that isn't quite implemented just yet.
Instead directories work for now but we can follow up with stricter path
filtering logic to plumb through all the arguments.
The rustc-generated function `main` should respect the same config for frame pointer elimination as the rest of code.
Environment variables on windows can't be empty.
`Token::Interpolated(Nonterminal)` -> `Token::Interpolated(Rc<Nonterminal>)`.
This reverts commit 41745f3.
* Correct the stability attributes. * Make Add and AddAssign actually behave the same. * Use String::with_capacity when allocating a new string. * Fix the tests.
On 64-bit platforms this reduces the size of `Expr` from 96 bytes to 88 bytes.
On 64-bit platforms this reduces the size of `Expr_` from 64 bytes to 56 bytes, and reduces the size of `Expr` from 88 bytes to 80 bytes.
|
💔 Test failed - auto-linux-64-cross-freebsd |
|
@bors: r+ force |
|
📌 Commit bdacb63 has been approved by |
|
⌛ Testing commit bdacb63 with merge b7b88bf... |
|
💔 Test failed - auto-win-msvc-64-opt |
|
@bors: retry force clean |
|
@bors: force |
This was referenced Nov 6, 2016
|
🎉 |
This was referenced Nov 6, 2016
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 11, 2016
Add changelog for 1.13.0 The diagnostics PRs are excellent and some have excellent examples thanks @jonathandturner @estebank. [Here are some notes about the performance changes during the release. Compile times are improved %40 in some cases](https://gist.github.com/brson/1404c4bf4868d7d108f240a6ecba7f31). This desires to be backported to beta for 1.13. Sadly, the [1.12.1 changelog PR](rust-lang#37317) has not merged to master yet, and is sitting in a [rollup PR](rust-lang#37597). r? @rust-lang/lang @rust-lang/compiler @rust-lang/libs @rust-lang/core
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 12, 2016
Add changelog for 1.13.0 The diagnostics PRs are excellent and some have excellent examples thanks @jonathandturner @estebank. [Here are some notes about the performance changes during the release. Compile times are improved %40 in some cases](https://gist.github.com/brson/1404c4bf4868d7d108f240a6ecba7f31). This desires to be backported to beta for 1.13. Sadly, the [1.12.1 changelog PR](rust-lang#37317) has not merged to master yet, and is sitting in a [rollup PR](rust-lang#37597). r? @rust-lang/lang @rust-lang/compiler @rust-lang/libs @rust-lang/core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hir::Exprslightly #37577, reference full path DefaultHasher #37579, Add-Z hir-statsfor collecting statistics on HIR and AST #37583, ChangeInto<Vec<u8>> for StringandInto<OsString> for PathBufto From #37585, fix #37559: update compiler-rt #37586, Remove recursive call from Cow::to_mut #37587, std: Track change to cprng syscall signature (Fuchsia) #37589, Add error when proc_macro_derive is used not on functions #37596