Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for last undocumented Default impl. #38186

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Add docs for last undocumented Default impl. #38186

merged 1 commit into from
Dec 7, 2016

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Dec 5, 2016

Add doc comment for Default impl on DefaultHasher.

Fixes #36265.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv mentioned this pull request Dec 5, 2016
Closed
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 5, 2016

r? @GuillaumeGomez

GuillaumeGomez
GuillaumeGomez reviewed Dec 6, 2016
View reviewed changes
src/libstd/collections/hash/map.rs
@@ -2108,6 +2108,10 @@ impl DefaultHasher {

#[stable(feature = "hashmap_default_hasher", since = "1.13.0")]
impl Default for DefaultHasher {
/// Creates a new `DefaultHasher` using [`DefaultHasher::new`]. See the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that "the" is need in here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Dec 7, 2016

📌 Commit 3cd9868 has been approved by GuillaumeGomez

@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 7, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 7, 2016
@GuillaumeGomez
Rollup merge of rust-lang#38186 - frewsxcv:default, r=GuillaumeGomez
ccbeb6d 
Add docs for last undocumented `Default` `impl`.

Add doc comment for `Default` `impl` on `DefaultHasher`.

Fixes rust-lang#36265.
bors added a commit that referenced this pull request Dec 7, 2016
@bors
Auto merge of #38214 - GuillaumeGomez:rollup, r=GuillaumeGomez
535b6d3 
Rollup of 9 pull requests

- Successful merges: #38085, #38123, #38151, #38153, #38158, #38163, #38186, #38189, #38208
- Failed merges:
@bors bors merged commit 3cd9868 into rust-lang:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @GuillaumeGomez @bors @alexcrichton