Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@@ -251,9 +251,11 @@ struct RcBox<T: ?Sized> {
/// See the [module-level documentation](./index.html) for more details.
///
/// The inherent methods of `Rc` are all associated functions, which means
/// that you have to call them as e.g. `Rc::get_mut(&value)` instead of
/// `value.get_mut()`. This avoids conflicts with methods of the inner
/// that you have to call them as e.g. [`Rc::get_mut(&value)`][get_mut] instead of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the rest of the file uses 79 (or 80?) characters for line length. Can you make this line match?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a lot of places, it goes beyond 80 columns so I don't see it as an issue?

@@ -127,20 +114,20 @@
//! ```
//!
//! If our requirements change, and we also need to be able to traverse from
//! `Owner` to `Gadget`, we will run into problems. An `Rc` pointer from `Owner`
//! `Owner` to `Gadget`, we will run into problems. An [`Rc`] pointer from `Owner`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And same answer. :p

@frewsxcv
Copy link
Contributor

frewsxcv commented Dec 7, 2016

r=me after line lengths are fixed

@frewsxcv
Copy link
Contributor

frewsxcv commented Dec 7, 2016

You're right, looks like it's 100 in other places in this file.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 7, 2016

📌 Commit 5caec61 has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 7, 2016
bors added a commit that referenced this pull request Dec 7, 2016
Rollup of 9 pull requests

- Successful merges: #38085, #38123, #38151, #38153, #38158, #38163, #38186, #38189, #38208
- Failed merges:
@bors bors merged commit 5caec61 into rust-lang:master Dec 7, 2016
@GuillaumeGomez GuillaumeGomez deleted the rc_links branch December 7, 2016 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants