Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force backline on all where in docs #39222

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Force backline on all where in docs #39222

merged 1 commit into from
Jan 24, 2017

Conversation

GuillaumeGomez
Copy link
Member

Pictures are better than words in this case:

Before:

screen shot 2017-01-21 at 15 34 27

After:

screen shot 2017-01-21 at 15 34 32

r? @steveklabnik

cc @rust-lang/docs

@steveklabnik
Copy link
Member

I'm fine with this. @rust-lang/tools ?

@alexcrichton
Copy link
Member

seems fine to me

@nrc
Copy link
Member

nrc commented Jan 24, 2017

+1

@GuillaumeGomez
Copy link
Member Author

I r+ it then. Just r- if you were waiting for others' confirmation.

@bors: r=frewsxcv,steveklabnik,alexcrichton,nrc rollup

@bors
Copy link
Collaborator

bors commented Jan 24, 2017

📌 Commit cbfc8fe has been approved by frewsxcv,steveklabnik,alexcrichton,nrc

@bors
Copy link
Collaborator

bors commented Jan 24, 2017

⌛ Testing commit cbfc8fe with merge fe597dc...

bors added a commit that referenced this pull request Jan 24, 2017
@bors
Auto merge of #39222 - GuillaumeGomez:rustdoc_where, r=frewsxcv,steve…
fe597dc 
…klabnik,alexcrichton,nrc

Force backline on all where in docs

Pictures are better than words in this case:

Before:

<img width="1440" alt="screen shot 2017-01-21 at 15 34 27" src="https://cloud.githubusercontent.com/assets/3050060/22175139/6e7c75d8-dfef-11e6-9904-023d63e609d2.png">

After:

<img width="1440" alt="screen shot 2017-01-21 at 15 34 32" src="https://cloud.githubusercontent.com/assets/3050060/22175140/75cc3846-dfef-11e6-9799-fffb213653e4.png">

r? @steveklabnik

cc @rust-lang/docs
@bors bors mentioned this pull request Jan 24, 2017
Merged
@bors
Copy link
Collaborator

bors commented Jan 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv,steveklabnik,alexcrichton,nrc
Pushing fe597dc to master...

@bors bors merged commit cbfc8fe into rust-lang:master Jan 24, 2017
@GuillaumeGomez GuillaumeGomez deleted the rustdoc_where branch January 24, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @steveklabnik @alexcrichton @nrc @bors @frewsxcv