rustbuild: Start building --enable-extended #39245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
enable-platform
branch
6 times, most recently
from
3560665 to
df0fb17
Compare
|
@brson ok I've updated with support for Windows as well, this should be good to go. |
alexcrichton
force-pushed
the
enable-platform
branch
2 times, most recently
from
e5391f9 to
3e6065f
Compare
brson
reviewed
Jan 24, 2017
| } else { | ||
| cmd.env("CFG_PLATFORM", "x86"); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is all amazing. Thank you.
|
This all looks great, but can we get rid of the 'platform' branding? How about r=me |
alexcrichton
force-pushed
the
enable-platform
branch
from
3e6065f to
e0c0368
Compare
alexcrichton
changed the title
|
@bors: r=brson |
|
📌 Commit e0c0368 has been approved by |
|
⌛ Testing commit e0c0368 with merge b69cb4b... |
|
💔 Test failed - status-travis |
|
@bors: r=brson |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit e0c0368 has been approved by |
alexcrichton
force-pushed
the
enable-platform
branch
from
e0c0368 to
3a31aab
Compare
|
@bors: r=brson |
|
📌 Commit 3a31aab has been approved by |
bors
added a commit
that referenced
this pull request
Jan 24, 2017
rustbuild: Start building --enable-extended This commit adds a new flag to the configure script, `--enable-extended`, which is intended for specifying a desire to compile the full suite of Rust tools such as Cargo, the RLS, etc. This is also an indication that the build system should create combined installers such as the pkg/exe/msi artifacts. Currently the `--enable-extended` flag just indicates that combined installers should be built, and Cargo is itself not compiled just yet but rather only downloaded from its location. The intention here is to quickly get to feature parity with the current release process and then we can start improving it afterwards. All new files in this PR inside `src/etc/installer` are copied from the rust-packaging repository. cc #38531
|
💔 Test failed - status-travis |
This commit adds a new flag to the configure script, `--enable-extended`, which is intended for specifying a desire to compile the full suite of Rust tools such as Cargo, the RLS, etc. This is also an indication that the build system should create combined installers such as the pkg/exe/msi artifacts. Currently the `--enable-extended` flag just indicates that combined installers should be built, and Cargo is itself not compiled just yet but rather only downloaded from its location. The intention here is to quickly get to feature parity with the current release process and then we can start improving it afterwards. All new files in this PR inside `src/etc/installer` are copied from the rust-packaging repository.
alexcrichton
force-pushed
the
enable-platform
branch
from
3a31aab to
f3dfcae
Compare
|
@bors: r=brson |
|
📌 Commit f3dfcae has been approved by |
bors
added a commit
that referenced
this pull request
Jan 24, 2017
rustbuild: Start building --enable-extended This commit adds a new flag to the configure script, `--enable-extended`, which is intended for specifying a desire to compile the full suite of Rust tools such as Cargo, the RLS, etc. This is also an indication that the build system should create combined installers such as the pkg/exe/msi artifacts. Currently the `--enable-extended` flag just indicates that combined installers should be built, and Cargo is itself not compiled just yet but rather only downloaded from its location. The intention here is to quickly get to feature parity with the current release process and then we can start improving it afterwards. All new files in this PR inside `src/etc/installer` are copied from the rust-packaging repository. cc #38531
38 tasks
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new flag to the configure script,
--enable-extended, which is intended for specifying a desire tocompile the full suite of Rust tools such as Cargo, the RLS, etc. This
is also an indication that the build system should create combined
installers such as the pkg/exe/msi artifacts.
Currently the
--enable-extendedflag just indicates that combinedinstallers should be built, and Cargo is itself not compiled just yet
but rather only downloaded from its location. The intention here is to
quickly get to feature parity with the current release process and then
we can start improving it afterwards.
All new files in this PR inside
src/etc/installerare copied from therust-packaging repository.
cc #38531