Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Show attributes on all item types #39654

Merged
merged 1 commit into from
Feb 12, 2017

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Feb 8, 2017

Currently attributes are only shown for structs, unions and enums but
they should be shown for all items. For example it is useful to know if a
function is #[no_mangle].

Currently attributes are only shown for structs, unions and enums but
they should be shown for all items. For example it is useful to know if a
function is `#[no_mangle]`.
@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member

Do you have a generated doc which displays the change please?

@ollie27
Copy link
Member Author

ollie27 commented Feb 12, 2017

https://ollie27.github.io/rust_doc_test/std/index.html has this change applied. The only change to the std docs is that lang items are now labelled (Add) just like must_use items are already shown (Result).

I assume you wanted these attributes displayed as you listed them in #37134.

@GuillaumeGomez
Copy link
Member

Oh nice! Thanks a lot! :)

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 12, 2017

📌 Commit 147d173 has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 12, 2017
…aumeGomez

rustdoc: Show attributes on all item types

Currently attributes are only shown for structs, unions and enums but
they should be shown for all items. For example it is useful to know if a
function is `#[no_mangle]`.
bors added a commit that referenced this pull request Feb 12, 2017
Rollup of 7 pull requests

- Successful merges: #39654, #39662, #39697, #39740, #39743, #39756, #39760
- Failed merges:
@bors bors merged commit 147d173 into rust-lang:master Feb 12, 2017
@ollie27 ollie27 deleted the rustdoc_attributes branch February 12, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants