Improve the style of the sidebar in rustdoc output #40265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
frewsxcv
added
A-docs
|
@bors: r+ rollup thanks! |
|
📌 Commit 5bc2687 has been approved by |
|
🔒 Merge conflict |
wesleywiser
force-pushed
the
rustdoc_style
branch
from
5bc2687 to
7509f4f
Compare
|
@steveklabnik rebased |
|
As far as I can tell, the build orchestration tool (powering bors) is currently broken, which is causing everything to be incorrectly errored as a merge conflict. We'll need to wait for that to get fixed before approving it again. |
|
Thanks! I was a little confused why my local repo didn't report a merge
conflict.
…On Sat, Mar 4, 2017, 11:20 PM Corey Farwell ***@***.***> wrote:
As far as I can tell, the build orchestration tool (powering bors) is
currently broken, which is causing everything to be incorrectly errored as
a merge conflict. We'll need to wait for that to get fixed before approving
it again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40265 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAyu2LlKvHJRE0C0ZockUxaXwp9YsLg7ks5rijgdgaJpZM4MTLZI>
.
|
GuillaumeGomez
requested changes
Mar 5, 2017
| @@ -163,11 +163,17 @@ nav.sub { | |||
| } | |||
|
|
|||
| .sidebar { | |||
| background-color: #F1F1F1; | |||
There was a problem hiding this comment.
color changes shouldn't be in this file but in src/librustdoc/html/static/styles/main.css.
| } | ||
|
|
||
| .sidebar .current { | ||
| background-color: white; |
| @@ -185,11 +191,16 @@ nav.sub { | |||
| } | |||
|
|
|||
| .sidebar .location { | |||
| border: black 1px solid; | |||
| @@ -38,7 +38,7 @@ pre { | |||
| } | |||
|
|
|||
| .sidebar .location { | |||
| background: #e1e1e1; | |||
| background-color: #fff; | |||
wesleywiser
force-pushed
the
rustdoc_style
branch
from
7509f4f to
6ae283a
Compare
|
@GuillaumeGomez Fixed |
GuillaumeGomez
requested changes
Mar 6, 2017
| @@ -185,11 +189,17 @@ nav.sub { | |||
| } | |||
|
|
|||
| .sidebar .location { | |||
| border-width: 1px; | |||
There was a problem hiding this comment.
Could be just:
border: 1px solid;Instead of:
border-width: 1px;
border-style: solid;There was a problem hiding this comment.
Thanks! I didn't even know you could do that.
Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856)
wesleywiser
force-pushed
the
rustdoc_style
branch
from
6ae283a to
2bb2a29
Compare
|
@GuillaumeGomez Fixed |
GuillaumeGomez
approved these changes
Mar 7, 2017
|
Thanks! @bors: r+ rollup |
|
📌 Commit 2bb2a29 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 8, 2017
…umeGomez Improve the style of the sidebar in rustdoc output Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856) Sample screenshots:   
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 8, 2017
…umeGomez Improve the style of the sidebar in rustdoc output Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856) Sample screenshots:   
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 8, 2017
…umeGomez Improve the style of the sidebar in rustdoc output Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856) Sample screenshots:   
bors
added a commit
that referenced
this pull request
Mar 9, 2017
This was referenced Mar 9, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently.
All visual design credit goes to @johnwhelchel (#37856)
Sample screenshots: