Document why str.to_{lower,upper}case return String
#40335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
CC @Havvy |
Havvy
suggested changes
Mar 7, 2017
src/libcollections/str.rs
Outdated
| @@ -1646,6 +1646,10 @@ impl str { | |||
| /// 'Lowercase' is defined according to the terms of the Unicode Derived Core Property | |||
| /// `Lowercase`. | |||
| /// | |||
| /// Since some characters can expand into multiple when changing the case, | |||
There was a problem hiding this comment.
I would say "multiple characters" instead of "multiple".
src/libcollections/str.rs
Outdated
| @@ -1718,6 +1722,10 @@ impl str { | |||
| /// 'Uppercase' is defined according to the terms of the Unicode Derived Core Property | |||
| /// `Uppercase`. | |||
| /// | |||
| /// Since some characters can expand into multiple when changing the case, | |||
tbu-
force-pushed
the
pr_doc_str_to_somecase
branch
from
45cf255 to
f3a2f90
Compare
|
@bors: r+ rollup thanks! |
|
📌 Commit f3a2f90 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 8, 2017
…eklabnik
Document why `str.to_{lower,upper}case` return `String`
Fixes rust-lang#39201.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 8, 2017
…eklabnik
Document why `str.to_{lower,upper}case` return `String`
Fixes rust-lang#39201.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 8, 2017
…eklabnik
Document why `str.to_{lower,upper}case` return `String`
Fixes rust-lang#39201.
bors
added a commit
that referenced
this pull request
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39201.