Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync all unstable features with Unstable Book; add tidy lint. #40694

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Sync all unstable features with Unstable Book; add tidy lint. #40694

merged 1 commit into from
Mar 31, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Mar 21, 2017 •
edited
Loading

Add a tidy lint that checks for...

  • Unstable Book sections with no corresponding SUMMARY.md links
  • unstable features that don't have Unstable Book sections
  • Unstable Book sections that don't have corresponding unstable features

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

r? @rust-lang/docs

@GuillaumeGomez
Copy link
Member

Urg, that's a LOT of code! Fine by me otherwise.

@frewsxcv
Copy link
Member Author

@GuillaumeGomez Which code are you talking about?

steveklabnik
steveklabnik previously requested changes Mar 21, 2017
View reviewed changes
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but one stylistic issue

src/doc/unstable-book/src/field-init-shorthand.md Outdated

[#37340]: https://github.com/rust-lang/rust/issues/37340

------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, I purposefully put these at the end of sections that do not have docs, just to keep it consistent; would you mind updating the ones you've added to have this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in the latest force push.

@bors
Copy link
Contributor

bors commented Mar 21, 2017

☔ The latest upstream changes (presumably #40693) made this pull request unmergeable. Please resolve the merge conflicts.

@ghost
Copy link

ghost commented Mar 21, 2017

I'm confused by the deletion of sort-unstable.md.
This is a new feature, not a stabilized one - am I missing something?

@frewsxcv
Copy link
Member Author

@stjepang sort_unstable hasn't landed in master yet, though I do see the open PR. If that one merges before this one, I'll remove the deletion.

@frewsxcv
Copy link
Member Author

Oh, the implementation of the feature landed five days ago. Huh, I'll have to check why my tidy lint wanted it deleted. Good catch

@ghost
Copy link

ghost commented Mar 21, 2017 •
edited by ghost
Loading

Actually, the PR for the feature was submitted 5 days ago, and it landed an hour ago.
Nothing wrong with tidy lint. You need a rebase at this point. :)

@frewsxcv
Copy link
Member Author

Anyone else see anything? If everything looks good, just give me a "r=me" thing. I don't want to approve this until after #40619 merges.

@frewsxcv frewsxcv mentioned this pull request Mar 23, 2017
Merged
@bors
Copy link
Contributor

bors commented Mar 23, 2017

☔ The latest upstream changes (presumably #40748) made this pull request unmergeable. Please resolve the merge conflicts.

@frewsxcv
Copy link
Member Author

#40619 merged. This is ready to go now. r? @steveklabnik

@frewsxcv
Copy link
Member Author

I have no idea what Travis is getting hung up on here. If anyone has thoughts, let me know.

@frewsxcv frewsxcv mentioned this pull request Mar 24, 2017
Merged
@frewsxcv
Copy link
Member Author

I don't want this to bit-rot while I try to debug this, so I extracted all the non-tidy-lint changes into a new PR: #40786

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 29, 2017
@frewsxcv
Add all unstable features to Unstable Book.
589e01f 
Add all unstable features to the Unstable Book, also remove a few that
either no longer exist or were promoted to stable.

These changes were extracted out of
rust-lang#40694
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 29, 2017
@frewsxcv
Rollup merge of rust-lang#40786 - frewsxcv:unstable-book-remaining-fe…
96dd9a9 
…atures, r=steveklabnik

Add all unstable features to Unstable Book.

Add all unstable features to the Unstable Book, also remove a few that
either no longer exist or were promoted to stable.

These changes were extracted out of
rust-lang#40694
@frewsxcv
Copy link
Member Author

This should be ready to go now.

r? @steveklabnik

@frewsxcv
Copy link
Member Author

@bors retry

timed out while trying to connect to github

@frewsxcv frewsxcv mentioned this pull request Mar 30, 2017
Closed
This was referenced Mar 30, 2017
Closed
Merged
@bors
Copy link
Contributor

bors commented Mar 31, 2017

⌛ Testing commit 53b35bd with merge 6acc9bf...

@bors
Copy link
Contributor

bors commented Mar 31, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member Author

@bors retry

@frewsxcv frewsxcv mentioned this pull request Mar 31, 2017
Closed
@bors
Copy link
Contributor

bors commented Mar 31, 2017

⌛ Testing commit 53b35bd with merge 09f9d21...

@frewsxcv
Sync all unstable features with Unstable Book; add tidy lint.
eef2a95 
Add a tidy lint that checks for...

* Unstable Book sections with no corresponding SUMMARY.md links
* unstable features that don't have Unstable Book sections
* Unstable Book sections that don't have corresponding unstable features
@frewsxcv
Copy link
Member Author

@bors r=steveklabnik p=1

new feature got added a few hours ago

going to give this a p=1 to make sure this stops getting out of sync

@bors
Copy link
Contributor

bors commented Mar 31, 2017

📌 Commit eef2a95 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 31, 2017
@frewsxcv
Rollup merge of rust-lang#40694 - frewsxcv:unstable-book-checker, r=s…
d2128fd 
…teveklabnik

Sync all unstable features with Unstable Book; add tidy lint.

Add a tidy lint that checks for...

* Unstable Book sections with no corresponding SUMMARY.md links
* unstable features that don't have Unstable Book sections
* Unstable Book sections that don't have corresponding unstable features
@frewsxcv frewsxcv mentioned this pull request Mar 31, 2017
Merged
bors added a commit that referenced this pull request Mar 31, 2017
@bors
Auto merge of #40950 - frewsxcv:rollup, r=frewsxcv
40feadb 
Rollup of 10 pull requests

- Successful merges: #40694, #40842, #40869, #40888, #40898, #40904, #40925, #40928, #40929, #40934
- Failed merges:
@bors bors merged commit eef2a95 into rust-lang:master Mar 31, 2017
@frewsxcv frewsxcv deleted the unstable-book-checker branch March 31, 2017 19:46
@frewsxcv frewsxcv mentioned this pull request Apr 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik left review comments

Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @GuillaumeGomez @bors @steveklabnik