Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve os::linux documentation (#29367) #40869

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Improve os::linux documentation (#29367) #40869

merged 1 commit into from
Mar 31, 2017

Conversation

ctjhoa
Copy link
Contributor

@ctjhoa ctjhoa commented Mar 27, 2017

Improve os::linux documentation according to #29367

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

steveklabnik
steveklabnik suggested changes Mar 27, 2017
View reviewed changes
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks! I have one tiny nit and then we can merge.

src/libstd/os/linux/fs.rs Outdated
#[stable(feature = "metadata_ext2", since = "1.8.0")]
fn st_rdev(&self) -> u64;
/// Returns the size of the file (if it is a regular file or a symbolic link) in bytes.
/// The size of a symbolic link is the length of the pathname it contains, without a terminating null byte.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a /// above this line? With markdown, just one \n doesn't actually cause a line break; it will bleed together as one paragraph. We try to usually have a short summary, a blank space, and then elaborate more 😄

@ctjhoa
Copy link
Contributor Author

ctjhoa commented Mar 28, 2017

@steveklabnik done

@steveklabnik
Copy link
Member

@bors: r+ rollup

awesome, thanks!

@bors
Copy link
Contributor

bors commented Mar 28, 2017

📌 Commit 732fe24 has been approved by steveklabnik

@frewsxcv
Copy link
Member

@bors r-

Looks like there's a tidy error:

/checkout/src/libstd/os/linux/fs.rs:60: line longer than 100 chars

@ctjhoa
Copy link
Contributor Author

ctjhoa commented Mar 31, 2017

@frewsxcv @steveklabnik this should be ok.

@steveklabnik
Copy link
Member

@bors: r+ rollup

👍

@bors
Copy link
Contributor

bors commented Mar 31, 2017

📌 Commit b36cff5 has been approved by steveklabnik

@frewsxcv frewsxcv mentioned this pull request Mar 31, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 31, 2017
@frewsxcv
Rollup merge of rust-lang#40869 - ctjhoa:master, r=steveklabnik
7ccd0b9 
Improve os::linux documentation (rust-lang#29367)

Improve `os::linux` documentation according to rust-lang#29367

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Mar 31, 2017
Merged
bors added a commit that referenced this pull request Mar 31, 2017
@bors
Auto merge of #40950 - frewsxcv:rollup, r=frewsxcv
40feadb 
Rollup of 10 pull requests

- Successful merges: #40694, #40842, #40869, #40888, #40898, #40904, #40925, #40928, #40929, #40934
- Failed merges:
@bors bors merged commit b36cff5 into rust-lang:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ctjhoa @rust-highfive @steveklabnik @bors @frewsxcv