-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appveyor: Downgrade MinGW to 6.2.0 #40865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the 6.3.0 MinGW comes with a gdb which has issues (rust-lang#40184) that an attempted workaround (rust-lang#40777) does not actually fix (rust-lang#40835). The original motivation for upgradin MinGW was to fix build flakiness (rust-lang#40546) due to newer builds not exhibiting the same bug, so let's hope that 6.2.0 isn't too far back in time and still contains the fix we need. Closes rust-lang#40835
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Let's see if this works. @bors r+ p=10 |
📌 Commit e87dd42 has been approved by |
⌛ Testing commit e87dd42 with merge dda4c6b... |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2017
…elb1 appveyor: Downgrade MinGW to 6.2.0 It looks like the 6.3.0 MinGW comes with a gdb which has issues (rust-lang#40184) that an attempted workaround (rust-lang#40777) does not actually fix (rust-lang#40835). The original motivation for upgradin MinGW was to fix build flakiness (rust-lang#40546) due to newer builds not exhibiting the same bug, so let's hope that 6.2.0 isn't too far back in time and still contains the fix we need. Closes rust-lang#40835
@bors: retry
|
bors
added a commit
that referenced
this pull request
Mar 27, 2017
⌛ Testing commit e87dd42 with merge c552cf3... |
@bors: retry
|
💔 Test failed - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the 6.3.0 MinGW comes with a gdb which has issues (#40184) that an
attempted workaround (#40777) does not actually fix (#40835). The original
motivation for upgradin MinGW was to fix build flakiness (#40546) due to newer
builds not exhibiting the same bug, so let's hope that 6.2.0 isn't too far back
in time and still contains the fix we need.
Closes #40835