-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change string references in asciiext #40837
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment: change "it's" to its
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Just need to fix a couple typos then this should be good to go!
src/libstd/ascii.rs
Outdated
/// ``` | ||
#[stable(feature = "rust1", since = "1.0.0")] | ||
fn is_ascii(&self) -> bool; | ||
|
||
/// Makes a copy of the string in ASCII upper case. | ||
/// Makes a copy of the value in it's ASCII upper case equivalent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"it's" → "its"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, well that's embarrassing. Fixed now :)
src/libstd/ascii.rs
Outdated
/// ``` | ||
/// | ||
/// [`make_ascii_uppercase`]: #tymethod.make_ascii_uppercase | ||
/// [`str::to_uppercase`]: ../primitive.str.html#method.to_uppercase | ||
#[stable(feature = "rust1", since = "1.0.0")] | ||
fn to_ascii_uppercase(&self) -> Self::Owned; | ||
|
||
/// Makes a copy of the string in ASCII lower case. | ||
/// Makes a copy of the value in it's ASCII lower case equivalent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto about "it's"
@bors: r+ rollup thanks a ton! ❤️ |
📌 Commit 1579fbd has been approved by |
change string references in asciiext
#40714 Updated AsciiExt docs and some examples