Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about char comparisons in constexprs #40976

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

matthewjasper
Copy link
Contributor

Fixes #40970 by evaluating const-exprs for comparisons on chars properly.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Apr 6, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 6, 2017

📌 Commit 2060266 has been approved by eddyb

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 6, 2017
Don't warn about `char` comparisons in constexprs

Fixes rust-lang#40970 by evaluating const-exprs for comparisons on `char`s properly.
bors added a commit that referenced this pull request Apr 6, 2017
Rollup of 8 pull requests

- Successful merges: #40878, #40976, #41089, #41090, #41108, #41111, #41112, #41114
- Failed merges:
@bors bors merged commit 2060266 into rust-lang:master Apr 7, 2017
@matthewjasper matthewjasper deleted the char-const-expr branch April 7, 2017 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants