Rollup of 8 pull requests #41121
Merged
Rollup of 8 pull requests #41121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a random stab towards rust-lang#38618, no idea if it'll work. But hey more up-to-date software is better, right?
This is a second (2/3?) step in order to complete this issue: rust-lang#29370 I submitted this PR with the help of @steveklabnik again. Thanks to him! More info here: rust-lang#29370 (comment)
Tuple fields don't have an `&T` in their declaration that can be changed to `&mut T` - skip them.. Fixes rust-lang#41104.
* Since the switch to pulldown-cmark reference links need a blank line before the URLs. * Reference link references are not case sensitive. * Doc comments need to be indented uniformly otherwise rustdoc gets confused.
Instead of rendering all of the HTML in rustdoc this relies on pulldown-cmark's `push_html` to do most of the work. A few iterator adapters are used to make rustdoc specific modifications to the output. This also fixes MarkdownHtml and link titles in plain_summary_line.
This initial commit provides implementations for HIR, MIR, and everything that also needs to be supported for those two.
Introduce HashStable trait and base ICH implementations on it. This PR introduces the `HashStable` trait which marks that a type can be hashed in a way that is stable across multiple compilation sessions. The PR also moves HIR incr. comp. hashing over to implementations of this trait instead of doing this via a HIR visitor. It also provides many `HashStable` implementations that are not used yet (e.g. for MIR types) but soon will be used when we directly hash crate metadata for incr. comp. I've only done superficial performance measurements but it looks like the new implementation is a bit faster than the current one (due, I suppose, to some bugs I fixed and some unnecessary inefficiencies I removed). Here is the time in seconds for the `compute_incremental_hashes_map` pass for various crates: | | OLD | NEW | |:---------------:|:-----:|:-----:| | libcore | 0.507 | 0.409 | | libsyntax | 0.320 | 0.260 | | librustc | 0.730 | 0.611 | | librustc_driver | 0.024 | 0.015 | Some notes regarding the implementation: * Most `HashStable` implementations are provided via the `impl_hash_stable_for!` macro (as suggested by @nikomatsakis). This works out quite well. A custom_derive would have been better but Macros 1.1 are not available in the compiler. * The trait implementation take care to exhaustively destructure everything they hash so that fields added in the future don't fall through the cracks. This is a bit verbose but I think it's well worth the trouble since we've had quite a few issues with missing fields or visitor callbacks in this area in the past. Most of it is behind the macro anyway. cc @rust-lang/compiler r? @nikomatsakis
Don't warn about `char` comparisons in constexprs Fixes rust-lang#40970 by evaluating const-exprs for comparisons on `char`s properly.
travis: Update musl for i686/x86_64 This is a random stab towards rust-lang#38618, no idea if it'll work. But hey more up-to-date software is better, right?
Add example to std::process::abort This is a second step in order to complete this issue: rust-lang#29370 I submitted this PR with the help of @steveklabnik again. Thanks to him! More info here: rust-lang#29370 (comment)
don't try to blame tuple fields for immutability Tuple fields don't have an `&T` in their declaration that can be changed to `&mut T` - skip them.. Fixes rust-lang#41104. r? @nikomatsakis
…umeGomez Fix Markdown issues in the docs * Since the switch to pulldown-cmark reference links need a blank line before the URLs. (rust-lang#40912) * Reference link references are not case sensitive. * Doc comments need to be indented uniformly otherwise rustdoc gets confused.
rustdoc: Use pulldown-cmark for Markdown HTML rendering Instead of rendering all of the HTML in rustdoc this relies on pulldown-cmark's `push_html` to do most of the work. A few iterator adapters are used to make rustdoc specific modifications to the output. This also fixes MarkdownHtml and link titles in plain_summary_line. https://ollie27.github.io/rust_doc_test/ is the docs built with this change and rust-lang#41111. Part of rust-lang#40912. cc @GuillaumeGomez r? @steveklabnik
.gitmodules: use the official Git URL w/o redirect
|
@bors r+ p=10 |
|
📌 Commit 8af853b has been approved by |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
⌛ Testing commit 8af853b with merge b8188a6... |
|
💔 Test failed - status-appveyor |
|
⌛ Testing commit 8af853b with merge 929d654... |
|
💔 Test failed - status-appveyor |
bors
added a commit
that referenced
this pull request
Apr 6, 2017
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charcomparisons in constexprs #40976, travis: Update musl for i686/x86_64 #41089, Add example to std::process::abort #41090, don't try to blame tuple fields for immutability #41108, Fix Markdown issues in the docs #41111, rustdoc: Use pulldown-cmark for Markdown HTML rendering #41112, .gitmodules: use the official Git URL w/o redirect #41114