Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #41121

Merged
merged 17 commits into from
Apr 7, 2017
Merged

Rollup of 8 pull requests #41121

merged 17 commits into from
Apr 7, 2017

Commits on Mar 31, 2017

  1. Configuration menu
    Copy the full SHA
    2060266 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2017

  1. travis: Update musl for i686/x86_64

    This is a random stab towards rust-lang#38618, no idea if it'll work. But hey more
    up-to-date software is better, right?
    alexcrichton committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    631f761 View commit details
    Browse the repository at this point in the history
  2. Add example to std::process::abort

    This is a second (2/3?) step in order to complete this issue: rust-lang#29370
    I submitted this PR with the help of @steveklabnik again. Thanks to him! More info here: rust-lang#29370 (comment)
    rap2hpoutre committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    4e1147f View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2017

  1. Update process.rs

    rap2hpoutre committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    16c77d7 View commit details
    Browse the repository at this point in the history
  2. don't try to blame tuple fields for immutability

    Tuple fields don't have an `&T` in their declaration that can be changed
    to `&mut T` - skip them..
    
    Fixes rust-lang#41104.
    arielb1 committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    95bd41e View commit details
    Browse the repository at this point in the history
  3. Fix Markdown issues in the docs

    * Since the switch to pulldown-cmark reference links need a blank line
    before the URLs.
    * Reference link references are not case sensitive.
    * Doc comments need to be indented uniformly otherwise rustdoc gets
    confused.
    ollie27 committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    b4be475 View commit details
    Browse the repository at this point in the history
  4. rustdoc: Use pulldown-cmark for Markdown HTML rendering

    Instead of rendering all of the HTML in rustdoc this relies on
    pulldown-cmark's `push_html` to do most of the work. A few iterator
    adapters are used to make rustdoc specific modifications to the output.
    
    This also fixes MarkdownHtml and link titles in plain_summary_line.
    ollie27 committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    f9fb381 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1f93a78 View commit details
    Browse the repository at this point in the history
  6. Introduce HashStable trait and base ICH implementations on it.

    This initial commit provides implementations for HIR, MIR, and
    everything that also needs to be supported for those two.
    michaelwoerister committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    c47cdc0 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#40878 - michaelwoerister:dmh, r=nikomatsakis

    Introduce HashStable trait and base ICH implementations on it.
    
    This PR introduces the `HashStable` trait which marks that a type can be hashed in a way that is stable across multiple compilation sessions. The PR also moves HIR incr. comp. hashing over to implementations of this trait instead of doing this via a HIR visitor. It also provides many `HashStable` implementations that are not used yet (e.g. for MIR types) but soon will be used when we directly hash crate metadata for incr. comp.
    
    I've only done superficial performance measurements but it looks like the new implementation is a bit faster than the current one (due, I suppose, to some bugs I fixed and some unnecessary inefficiencies I removed). Here is the time in seconds for the `compute_incremental_hashes_map` pass for various crates:
    
    |                 |  OLD  |  NEW  |
    |:---------------:|:-----:|:-----:|
    | libcore         | 0.507 | 0.409 |
    | libsyntax       | 0.320 | 0.260 |
    | librustc        | 0.730 | 0.611 |
    | librustc_driver | 0.024 | 0.015 |
    
    Some notes regarding the implementation:
    * Most `HashStable` implementations are provided via the `impl_hash_stable_for!` macro (as suggested by @nikomatsakis). This works out quite well. A custom_derive would have been better but Macros 1.1 are not available in the compiler.
    * The trait implementation take care to exhaustively destructure everything they hash so that fields added in the future don't fall through the cracks. This is a bit verbose but I think it's well worth the trouble since we've had quite a few issues with missing fields or visitor callbacks in this area in the past. Most of it is behind the macro anyway.
    
    cc @rust-lang/compiler
    r? @nikomatsakis
    frewsxcv committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    cce5c2d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#40976 - matthewjasper:char-const-expr, r=eddyb

    Don't warn about `char` comparisons in constexprs
    
    Fixes rust-lang#40970 by evaluating const-exprs for comparisons on `char`s properly.
    frewsxcv committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    966878e View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#41089 - alexcrichton:update-musl, r=brson

    travis: Update musl for i686/x86_64
    
    This is a random stab towards rust-lang#38618, no idea if it'll work. But hey more
    up-to-date software is better, right?
    frewsxcv committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    9516c80 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#41090 - rap2hpoutre:patch-2, r=steveklabnik

    Add example to std::process::abort
    
    This is a second step in order to complete this issue: rust-lang#29370
    I submitted this PR with the help of @steveklabnik again. Thanks to him! More info here: rust-lang#29370 (comment)
    frewsxcv committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    a750276 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#41108 - arielb1:tuple-blame, r=estebank

    don't try to blame tuple fields for immutability
    
    Tuple fields don't have an `&T` in their declaration that can be changed
    to `&mut T` - skip them..
    
    Fixes rust-lang#41104.
    
    r? @nikomatsakis
    frewsxcv committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    30477a8 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#41111 - ollie27:docs_markdown_fix, r=Guilla…

    …umeGomez
    
    Fix Markdown issues in the docs
    
    * Since the switch to pulldown-cmark reference links need a blank line
    before the URLs. (rust-lang#40912)
    * Reference link references are not case sensitive.
    * Doc comments need to be indented uniformly otherwise rustdoc gets
    confused.
    frewsxcv committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    202be73 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#41112 - ollie27:rustdoc_pull, r=GuillaumeGomez

    rustdoc: Use pulldown-cmark for Markdown HTML rendering
    
    Instead of rendering all of the HTML in rustdoc this relies on
    pulldown-cmark's `push_html` to do most of the work. A few iterator
    adapters are used to make rustdoc specific modifications to the output.
    
    This also fixes MarkdownHtml and link titles in plain_summary_line.
    
    https://ollie27.github.io/rust_doc_test/ is the docs built with this change and rust-lang#41111.
    
    Part of rust-lang#40912.
    
    cc @GuillaumeGomez
    
    r? @steveklabnik
    frewsxcv committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    f129c0c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#41114 - nodakai:patch-2, r=petrochenkov

    .gitmodules: use the official Git URL w/o redirect
    frewsxcv committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    8af853b View commit details
    Browse the repository at this point in the history