Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPYRIGHT: remove hoedown license #41183

Merged
merged 1 commit into from
Apr 12, 2017

Conversation

nodakai
Copy link
Contributor

@nodakai nodakai commented Apr 10, 2017

Hoedown was removed in b96fef8

Also cleanup src/tools/tidy/src/main.rs

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

Removing the hoedown stuff makes sense to me. @alexcrichton I am 99% sure these tidy changes do to, but wdyt?

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 10, 2017

📌 Commit bfb9e01 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 11, 2017

⌛ Testing commit bfb9e01 with merge dfb5d77...

@bors
Copy link
Contributor

bors commented Apr 11, 2017

💔 Test failed - status-travis

"src/rustllvm",
"src/rust-installer",
"src/liblibc",
"src/tools/cargo",
"src/vendor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of this line causes tidy errors during dist-check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact several issues are preventing me from completing x.py test distcheck locally... Just blindly reverted the last line

Hoedown was removed in b96fef8

Also cleanup src/tools/tidy/src/main.rs

Signed-off-by: NODA, Kai <nodakai@gmail.com>
@nodakai nodakai force-pushed the remove-hoedown-license branch from bfb9e01 to f391451 Compare April 12, 2017 04:55
@TimNN
Copy link
Contributor

TimNN commented Apr 12, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Apr 12, 2017

📌 Commit f391451 has been approved by TimNN

TimNN added a commit to TimNN/rust that referenced this pull request Apr 12, 2017
…imNN

COPYRIGHT: remove hoedown license

Hoedown was removed in b96fef8

Also cleanup src/tools/tidy/src/main.rs
bors added a commit that referenced this pull request Apr 12, 2017
Rollup of 9 pull requests

- Successful merges: #41063, #41087, #41141, #41166, #41183, #41205, #41206, #41232, #41243
- Failed merges:
@bors bors merged commit f391451 into rust-lang:master Apr 12, 2017
@nodakai nodakai deleted the remove-hoedown-license branch April 12, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants