Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #41188

Closed
wants to merge 0 commits into from
Closed

Rollup of 4 pull requests #41188

wants to merge 0 commits into from

Conversation

@frewsxcv
Copy link
Member Author

@bors r+ p=10

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Contributor

bors commented Apr 10, 2017

📌 Commit 73e26a5 has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Apr 10, 2017

⌛ Testing commit 73e26a5 with merge 62a33c9...

@bors
Copy link
Contributor

bors commented Apr 10, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Apr 10, 2017 via email

@bors
Copy link
Contributor

bors commented Apr 10, 2017

⌛ Testing commit 73e26a5 with merge 38230af...

@bors
Copy link
Contributor

bors commented Apr 10, 2017

💔 Test failed - status-appveyor

@TimNN
Copy link
Contributor

TimNN commented Apr 10, 2017

@bors
Copy link
Contributor

bors commented Apr 10, 2017

⌛ Testing commit 73e26a5 with merge 1984027...

@bors
Copy link
Contributor

bors commented Apr 10, 2017

💔 Test failed - status-travis

@TimNN
Copy link
Contributor

TimNN commented Apr 10, 2017

[00:00:00] +++dirname src/ci/init_repo.sh
[00:00:00] ++cd src/ci
[00:00:00] ++pwd
[00:00:00] +ci_dir=/Users/travis/build/rust-lang/rust/src/ci
[00:00:00] +. /Users/travis/build/rust-lang/rust/src/ci/shared.sh
[00:00:00] +REPO_DIR=.
[00:00:00] +CACHE_DIR=/Users/travis/rustsrc
[00:00:00] +cache_src_dir=/Users/travis/rustsrc/src
[00:00:00] +cache_valid_file=/Users/travis/rustsrc/cache_valid1
[00:00:00] +'[' '!' -d . -o '!' -d ./.git ']'
[00:00:00] +cd .
[00:00:00] +'[' '!' -d /Users/travis/rustsrc ']'
[00:00:00] +'[' '!' -f /Users/travis/rustsrc/cache_valid1 ']'
[00:00:00] +set +o errexit
[00:00:00] ++cd /Users/travis/rustsrc/src
[00:00:00] ++git status --porcelain
[00:00:00] ++wc -l
[00:00:01] fatal: Not a git repository: src/compiler-rt/../../.git/modules/src/compiler-rt
[00:00:01] +stat_lines='       0'
[00:00:01] ++cd /Users/travis/rustsrc/src
[00:00:01] ++git status
[00:00:02] ++echo 128
[00:00:02] +stat_ec=128
[00:00:02] +set -o errexit
[00:00:02] +'[' '!' -d /Users/travis/rustsrc/src/.git -o 0 '!=' 0 -o 128 '!=' 0 ']'
[00:00:02] +echo 'WARNING: /Users/travis/rustsrc/cache_valid1 exists but bad repo: l:       0, ec:128'
[00:00:02] +rm -rf /Users/travis/rustsrc
[00:00:02] WARNING: /Users/travis/rustsrc/cache_valid1 exists but bad repo: l:       0, ec:128
[00:00:15] rm: /Users/travis/rustsrc/src: Directory not empty
[00:00:15] rm: /Users/travis/rustsrc: Directory not empty

cc @aidanhs

@aidanhs
Copy link
Member

aidanhs commented Apr 10, 2017

adding /Users/travis/rustsrc to cache
creating directory /Users/travis/rustsrc
running `casher add/Users/travis/docker /Users/travis/rustsrc` took longer than 180 seconds and has been aborted

ok, restoring the cache was aborted. This is fine, the paranoia script will just nuke it, as it then attempted. But rm -rf printing things like "directory not empty" sounds like either a bad disk or a network drive. Looking at the partitions:

$ echo "#### Build failed; Disk usage after running script:"; df -h; du . | sort -nr | head -n100
    
#### Build failed; Disk usage after running script:
Filesystem      Size   Used  Avail Capacity  iused    ifree %iused  Mounted on
/dev/disk0s2   149Gi   71Gi   78Gi    48% 18580816 20530880   48%   /
devfs          176Ki  176Ki    0Bi   100%      608        0  100%   /dev
map -hosts       0Bi    0Bi    0Bi   100%        0        0  100%   /net
map auto_home    0Bi    0Bi    0Bi   100%        0        0  100%   /home
[...]

auto_home sounds suspiciously like a network drive, especially after searching online.

I would submit a PR to remove caching logic from everywhere, but that wouldn't have helped in this case - the git submodule deinit -f . && git submodule update --init loop that existed previously would also have blown up. I've created #41201 to track this issue, I don't have any better immediate suggestion than a retry.

@frewsxcv frewsxcv closed this Apr 11, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants