Don't panic if an attribute macro fails to resolve at crate root #41432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds temporary regression test; this ideally should work as-is (rust-lang#41430) Closes rust-lang#41211
|
Thanks @abonander! We'll check up on this PR periodically to make sure that @jseyfried or another reviewer gets to it in a timely manner! |
shepmaster
added
the
S-waiting-on-review
|
@abonander Thanks, looks good! |
|
📌 Commit 910532e has been approved by |
shepmaster
added
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 22, 2017
Don't panic if an attribute macro fails to resolve at crate root Adds temporary regression test; this ideally should work as-is (rust-lang#41430) Closes rust-lang#41211 r? @jseyfried
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 22, 2017
Don't panic if an attribute macro fails to resolve at crate root Adds temporary regression test; this ideally should work as-is (rust-lang#41430) Closes rust-lang#41211 r? @jseyfried
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 22, 2017
Don't panic if an attribute macro fails to resolve at crate root Adds temporary regression test; this ideally should work as-is (rust-lang#41430) Closes rust-lang#41211 r? @jseyfried
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds temporary regression test; this ideally should work as-is (#41430)
Closes #41211
r? @jseyfried