-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #41459
Rollup of 4 pull requests #41459
Conversation
frewsxcv
commented
Apr 22, 2017
- Successful merges: Ref suggestion #37658, Fix line display for hoedown #41405, Don't panic if an attribute macro fails to resolve at crate root #41432, Add test for issue 33884 #41435
- Failed merges:
Adds temporary regression test; this ideally should work as-is (rust-lang#41430) Closes rust-lang#41211
…komatsakis,eddyb Ref suggestion
…ovement, r=steveklabnik Fix line display for hoedown Fixes rust-lang#41401. r? @rust-lang/docs
Don't panic if an attribute macro fails to resolve at crate root Adds temporary regression test; this ideally should work as-is (rust-lang#41430) Closes rust-lang#41211 r? @jseyfried
Add test for issue 33884 Fix rust-lang#33884. r=nikomatsakis
@bors r+ p=10 |
📌 Commit df72158 has been approved by |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
⌛ Testing commit df72158 with merge ff13b7c... |
☀️ Test successful - status-appveyor, status-travis |