-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unstable features from rustc_errors #41837
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
@@ -1200,8 +1200,12 @@ fn num_overlap(a_start: usize, a_end: usize, b_start: usize, b_end:usize, inclus | |||
} else { | |||
0 | |||
}; | |||
(b_start..b_end + extra).contains(a_start) || | |||
(a_start..a_end + extra).contains(b_start) | |||
return range_contains(b_start..b_end + extra, a_start) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not be simpler just to have the following? Maybe with a comment for clarity.
(b_start <= a_start && a_start < b_end + extra) ||
(a_start <= b_start && b_start < a_end + extra);
@bors r+ |
📌 Commit 7120279 has been approved by |
Oh well. The multiple libcs cause the docs tests that use libc to fail:
@bors r- |
☔ The latest upstream changes (presumably #41847) made this pull request unmergeable. Please resolve the merge conflicts. |
No description provided.