rustc: Add a new `-Z force-unstable-if-unmarked` flag #41847

alexcrichton · 2017-05-09T03:38:27Z

This commit adds a new -Z flag to the compiler for use when bootstrapping the
compiler itself. We want to be able to use crates.io crates, but we also want
the usage of such crates to be as ergonomic as possible! To that end compiler
crates are a little tricky in that the crates.io crates are not annotated as
unstable, nor do they expect to pull in unstable dependencies.

To cover all these situations it's intended that the compiler will forever now
bootstrap with -Z force-unstable-if-unmarked. This flags serves a dual purpose
of forcing crates.io crates to themselves be unstable while also allowing them
to use other "unstable" crates.io crates. This should mean that adding a
dependency to compiler no longer requires upstream modification with
unstable/staged_api attributes for inclusion!

alexcrichton · 2017-05-09T03:38:38Z

cc @eddyb

rust-highfive · 2017-05-09T03:38:39Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2017-05-09T03:43:54Z

src/bootstrap/bin/rustc.rs

@@ -194,6 +194,8 @@ fn main() {
                // do that we pass a weird flag to the compiler to get it to do
                // so. Note that this is definitely a hack, and we should likely
                // flesh out rpath support more fully in the future.
+                //
+                // TODO: remove condition after next stage0


This is unrelated to this PR's primary changes, right? Just want to make sure...

Indeed! I just remembered to touch it up in this PR

pitdicker · 2017-05-09T09:59:28Z

src/librustc/middle/stability.rs

+        // with the `rustc_private` feature. This is intended for use when
+        // compiling librustc crates themselves so we can leverage crates.io
+        // while maintaining the invariant that all sysroort crates are unstable
+        // by default an are unable to be used.


*sysroot, *and

bors · 2017-05-09T14:35:22Z

☔ The latest upstream changes (presumably #41709) made this pull request unmergeable. Please resolve the merge conflicts.

eddyb · 2017-05-10T07:12:45Z

src/librustc/session/config.rs

@@ -1027,6 +1027,8 @@ options! {DebuggingOptions, DebuggingSetter, basic_debugging_options,
        "add a source pattern to the file path remapping config"),
    remap_path_prefix_to: Vec<String> = (vec![], parse_string_push, [TRACKED],
        "add a mapping target to the file path remapping config"),
+    force_unstable_if_unmarked: bool = (false, parse_bool, [TRACKED],
+        "force all crates to be `rustc_private` unstable"),


Could the `rustc_private be provided from rustbuild instead if being hardcoded?

We could, yeah, but I'm not sure it'd buy much? We otherwise would still hardcode the issue number as well as the description of the unstable feature (the "note"), and passing all that info as CLI flags may not also be worth it :(.

Do you think we'll want different unstable features on differnet crates though?

It's more that the flag name doesn't seem specific to rustc_private. I don't care too much anyway.

Heh we could also call it -Z tag-this-crate-with-rustc-private-unstable-feature-if-otherwise-unmarked

eddyb · 2017-05-10T07:15:25Z

src/librustc/middle/stability.rs

+        let is_staged_api = self.lookup_stability(DefId {
+            index: CRATE_DEF_INDEX,
+            ..def_id
+        }).is_some();


Aah this is what I didn't consider refactoring - it's much nicer!

This commit adds a new `-Z` flag to the compiler for use when bootstrapping the compiler itself. We want to be able to use crates.io crates, but we also want the usage of such crates to be as ergonomic as possible! To that end compiler crates are a little tricky in that the crates.io crates are not annotated as unstable, nor do they expect to pull in unstable dependencies. To cover all these situations it's intended that the compiler will forever now bootstrap with `-Z force-unstable-if-unmarked`. This flags serves a dual purpose of forcing crates.io crates to themselves be unstable while also allowing them to use other "unstable" crates.io crates. This should mean that adding a dependency to compiler no longer requires upstream modification with unstable/staged_api attributes for inclusion!

Mark-Simulacrum · 2017-05-11T22:46:51Z

Legitimate tidy errors.

[00:01:56] Building stage0 tool tidy (x86_64-unknown-linux-gnu)
[00:01:57]    Compiling tidy v0.1.0 (file:///checkout/src/tools/tidy)
[00:02:04]     Finished release [optimized] target(s) in 6.87 secs
[00:02:04] tidy check (x86_64-unknown-linux-gnu)
[00:02:04] tidy error: /checkout/src/bootstrap/bin/rustc.rs:198: TODO is deprecated; use FIXME
[00:02:04] tidy error: /checkout/src/bootstrap/bin/rustc.rs:228: TODO is deprecated; use FIXME
[00:02:04] tidy error: /checkout/src/bootstrap/lib.rs:529: TODO is deprecated; use FIXME
[00:02:05] some tidy checks failed

These are now no longer necessary with `-Z force-unstable-if-unmarked`

alexcrichton · 2017-05-11T23:03:13Z

Fixed!

alexcrichton · 2017-05-11T23:03:30Z

I think @pnkfelix may be on leave, @eddyb mind reviewing this?

eddyb · 2017-05-12T05:11:47Z

@bors r+

bors · 2017-05-12T05:11:48Z

📌 Commit ab54f4b has been approved by eddyb

Mark-Simulacrum · 2017-05-12T12:59:12Z

@bors p=1

Giving higher priority since I know this blocks at least a few other PRs.

…ons, r=eddyb rustc: Add a new `-Z force-unstable-if-unmarked` flag This commit adds a new `-Z` flag to the compiler for use when bootstrapping the compiler itself. We want to be able to use crates.io crates, but we also want the usage of such crates to be as ergonomic as possible! To that end compiler crates are a little tricky in that the crates.io crates are not annotated as unstable, nor do they expect to pull in unstable dependencies. To cover all these situations it's intended that the compiler will forever now bootstrap with `-Z force-unstable-if-unmarked`. This flags serves a dual purpose of forcing crates.io crates to themselves be unstable while also allowing them to use other "unstable" crates.io crates. This should mean that adding a dependency to compiler no longer requires upstream modification with unstable/staged_api attributes for inclusion!

Rollup of 15 pull requests - Successful merges: #41820, #41843, #41847, #41860, #41896, #41912, #41916, #41918, #41919, #41921, #41923, #41934, #41940, #41942, #41943 - Failed merges: #41914

bors · 2017-05-13T05:22:15Z

⌛ Testing commit ab54f4b with merge 4f3886a...

rustc: Add a new `-Z force-unstable-if-unmarked` flag This commit adds a new `-Z` flag to the compiler for use when bootstrapping the compiler itself. We want to be able to use crates.io crates, but we also want the usage of such crates to be as ergonomic as possible! To that end compiler crates are a little tricky in that the crates.io crates are not annotated as unstable, nor do they expect to pull in unstable dependencies. To cover all these situations it's intended that the compiler will forever now bootstrap with `-Z force-unstable-if-unmarked`. This flags serves a dual purpose of forcing crates.io crates to themselves be unstable while also allowing them to use other "unstable" crates.io crates. This should mean that adding a dependency to compiler no longer requires upstream modification with unstable/staged_api attributes for inclusion!

bors · 2017-05-13T07:47:06Z

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 4f3886a to master...

rust-highfive assigned pnkfelix May 9, 2017

Mark-Simulacrum reviewed May 9, 2017

View reviewed changes

arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2017

pitdicker reviewed May 9, 2017

View reviewed changes

alexcrichton force-pushed the less-unstable-annotations branch from d019abb to deafeca Compare May 9, 2017 14:46

eddyb reviewed May 10, 2017

View reviewed changes

eddyb mentioned this pull request May 10, 2017

Use stacker to prevent stack overflow from depth-first query evaluation. #41884

Closed

alexcrichton force-pushed the less-unstable-annotations branch from deafeca to 43cd756 Compare May 10, 2017 14:42

alexcrichton added 2 commits May 11, 2017 16:03

rustbuild: Use -Z force-unstable-if-unmarked

af0e16c

rustc: Remove #![unstable] annotation

ab54f4b

These are now no longer necessary with `-Z force-unstable-if-unmarked`

alexcrichton force-pushed the less-unstable-annotations branch from 43cd756 to ab54f4b Compare May 11, 2017 23:03

Mark-Simulacrum mentioned this pull request May 12, 2017

Rollup of 15 pull requests #41945

Closed

Mark-Simulacrum mentioned this pull request May 12, 2017

Rollup of 13 pull requests #41947

Closed

Mark-Simulacrum mentioned this pull request May 12, 2017

Rollup of 15 pull requests #41954

Closed

bors merged commit ab54f4b into rust-lang:master May 13, 2017

hanna-kruppe mentioned this pull request May 14, 2017

Make only rustc_trans depend on rustc_llvm #41565

Merged

Mark-Simulacrum mentioned this pull request May 16, 2017

Add warnings when rustdoc html rendering differs #41991

Merged

alexcrichton mentioned this pull request May 24, 2017

Review which hash algorithm to use for incremental compilation hashes. #41215

Closed

alexcrichton deleted the less-unstable-annotations branch June 14, 2017 18:40

kennytm mentioned this pull request Jun 20, 2017

Current libc integration is a huge hack #42773

Closed

kennytm mentioned this pull request Aug 16, 2017

incr.comp.: Crate Metadata not corresponding to a DefId is untracked. #41417

Closed

retep998 mentioned this pull request Sep 10, 2017

RFC: Clarify and streamline paths and visibility rust-lang/rfcs#2126

Merged

petrochenkov mentioned this pull request Jun 10, 2019

lexer: Disallow bare CR in raw byte strings #60793

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustc: Add a new `-Z force-unstable-if-unmarked` flag #41847

rustc: Add a new `-Z force-unstable-if-unmarked` flag #41847

alexcrichton commented May 9, 2017

alexcrichton commented May 9, 2017

rust-highfive commented May 9, 2017

Mark-Simulacrum May 9, 2017

alexcrichton May 9, 2017

pitdicker May 9, 2017

bors commented May 9, 2017

eddyb May 10, 2017

alexcrichton May 10, 2017

eddyb May 10, 2017

alexcrichton May 10, 2017

eddyb May 10, 2017

Mark-Simulacrum commented May 11, 2017

alexcrichton commented May 11, 2017

alexcrichton commented May 11, 2017

eddyb commented May 12, 2017

bors commented May 12, 2017

Mark-Simulacrum commented May 12, 2017

bors commented May 13, 2017

bors commented May 13, 2017

rustc: Add a new -Z force-unstable-if-unmarked flag #41847

rustc: Add a new -Z force-unstable-if-unmarked flag #41847

Conversation

alexcrichton commented May 9, 2017

alexcrichton commented May 9, 2017

rust-highfive commented May 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bors commented May 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mark-Simulacrum commented May 11, 2017

alexcrichton commented May 11, 2017

alexcrichton commented May 11, 2017

eddyb commented May 12, 2017

bors commented May 12, 2017

Mark-Simulacrum commented May 12, 2017

bors commented May 13, 2017

bors commented May 13, 2017

rustc: Add a new `-Z force-unstable-if-unmarked` flag #41847

rustc: Add a new `-Z force-unstable-if-unmarked` flag #41847