Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env docs completion. #42579

Merged
merged 1 commit into from
Jun 12, 2017
Merged

env docs completion. #42579

merged 1 commit into from
Jun 12, 2017

Conversation

maccoda
Copy link
Contributor

@maccoda maccoda commented Jun 10, 2017

Should be closing #29351 with the alignment of the iterators to the template.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@maccoda
Copy link
Contributor Author

maccoda commented Jun 10, 2017

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Jun 10, 2017
@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2017
@frewsxcv frewsxcv added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jun 11, 2017
@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks so much!

@bors
Copy link
Contributor

bors commented Jun 12, 2017

📌 Commit f52ac18 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 12, 2017
@frewsxcv
Rollup merge of rust-lang#42579 - maccoda:maccoda/env_docs, r=stevekl…
3a550a4 
…abnik

env docs completion.

Should be closing rust-lang#29351 with the alignment of the iterators to the template.
@frewsxcv frewsxcv mentioned this pull request Jun 12, 2017
Merged
bors added a commit that referenced this pull request Jun 12, 2017
@bors
Auto merge of #42605 - frewsxcv:rollup, r=frewsxcv
cfb5deb 
Rollup of 4 pull requests

- Successful merges: #42579, #42586, #42592, #42594
- Failed merges:
@bors bors merged commit f52ac18 into rust-lang:master Jun 12, 2017
@steveklabnik steveklabnik mentioned this pull request Jul 27, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maccoda @rust-highfive @steveklabnik @bors @brson @frewsxcv @Mark-Simulacrum