Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Link directly to associated types #42594

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jun 11, 2017

Rather than just linking to the trait.

Also simplifies the logic used to decide whether to render the full
QPath.

Rather than just linking to the trait.

Also simplifies the logic used to decide whether to render the full
QPath.
@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv frewsxcv added the T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. label Jun 11, 2017
@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2017
@steveklabnik
Copy link
Member

Nice, thank you!

@bors: r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2017

📌 Commit 429dc51 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 12, 2017
…=steveklabnik

rustdoc: Link directly to associated types

Rather than just linking to the trait.

Also simplifies the logic used to decide whether to render the full
QPath.
bors added a commit that referenced this pull request Jun 12, 2017
Rollup of 4 pull requests

- Successful merges: #42579, #42586, #42592, #42594
- Failed merges:
@bors bors merged commit 429dc51 into rust-lang:master Jun 12, 2017
@bors
Copy link
Collaborator

bors commented Jun 12, 2017

⌛ Testing commit 429dc51 with merge cfb5deb...

@ollie27 ollie27 deleted the rustdoc_assoc_type_links branch June 13, 2017 10:27
@Mark-Simulacrum
Copy link
Member

@bors retry

@ollie27
Copy link
Member Author

ollie27 commented Jun 17, 2017

huh? this is already merged, is @bors confused?

@Mark-Simulacrum
Copy link
Member

Yeah, just fixing bors.

@bors
Copy link
Collaborator

bors commented Jun 18, 2017

⌛ Testing commit 429dc51 with merge 78d8416...

@Mark-Simulacrum
Copy link
Member

Bors.. what...

@bors r-

@bors retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants