E05XX odyssey #43726
E05XX odyssey #43726
Conversation
src/librustc_passes/diagnostics.rs
Outdated
| "##, | ||
|
|
||
| E0571: r##" | ||
| The `break` statement can take an argument (which will be the value of the loop |
There was a problem hiding this comment.
A long error explanation is supposed to start by a short summary of the error. The error explanation comes just after the erroneous code example and just before the fix.
src/libsyntax/diagnostic_list.rs
Outdated
| E0552: r##" | ||
| A unrecognized representation attribute was used. | ||
|
|
||
| You can use a `repr` attribute to tell the compiler how you want a struct or |
There was a problem hiding this comment.
The explanation is supposed to be after the erroneous code example.
|
|
||
| Example of erroneous code (on a stable compiler): | ||
|
|
||
| ```ignore (depends on release channel) |
There was a problem hiding this comment.
@GuillaumeGomez Just writing ignore without explanation will cause tidy failure. --explain will strip them out though.
src/libsyntax/diagnostic_list.rs
Outdated
| "##, | ||
|
|
||
| E0557: r##" | ||
| A feature attribute for a removed feature was used. |
There was a problem hiding this comment.
Seems a bit complicated when formulated this way.
| @@ -1602,7 +1602,7 @@ fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate, | |||
| if attr.check_name("feature") { | |||
| let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)"); | |||
| span_err!(span_handler, attr.span, E0554, | |||
| "#[feature] may not be used on the {} release channel", | |||
| "#![feature] may not be used on the {} release channel", | |||
There was a problem hiding this comment.
See the commit message.
arielb1
added
the
S-waiting-on-author
It's more pleasing to use the inner-attribute syntax (`#!` rather than `#`) in the error message, as that is how `feature` attributes in particular will be declared (as they apply to the entire crate).
zackmdavis
force-pushed
the
extended_information_summer_block_party
branch
from
6e43cfd to
116bf07
Compare
|
(updated) |
|
Thanks! @bors: r+ |
|
📌 Commit 116bf07 has been approved by |
…arty, r=GuillaumeGomez E05XX odyssey chipping away at the surface exposed by #43709 r? @GuillaumeGomez
|
☀️ Test successful - status-appveyor, status-travis |
chipping away at the surface exposed by #43709
r? @GuillaumeGomez