de-orphan extended information #43709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bizarrely, librustc_passes, librustc_plugin, librustc_mir, and libsyntax weren't getting their error explanations registered. Resolves rust-lang#35284.
After repatriating error explanations to the global registry, some lurking doctest failures surfaced and needed to be chased down. Sadly, a few doctests needed to be ignored due to a not-yet-understood regression in the doctest `compile_fail` functionality (filed rust-lang#43707).
The sole appearance of this code was deleted in 6383de1; the existing practice in these cases seems to be to comment out its mention in `register_diagnostics!`.
|
Wo perfect! I just saw it yesterday and was investigating on it so your PR arrives just on time. Thanks a lot! @bors: r+ p=1 |
|
📌 Commit 75b7a6f has been approved by |
bors
added a commit
that referenced
this pull request
Aug 7, 2017
…uillaumeGomez de-orphan extended information Bizarrely, librustc_passes, librustc_plugin, librustc_mir, and libsyntax [weren't getting their error explanations registered](#35284) (leaving _several_ error codes absent from [the index](https://doc.rust-lang.org/nightly/error-index.html) and `--explain`). This surfaced a few latent doctest failures that were fixed where readily possible and ignored (with a recorded excuse) if not. Also, we don't issue E0563 anymore. r? @GuillaumeGomez
|
☀️ Test successful - status-appveyor, status-travis |
Merged
bors
added a commit
that referenced
this pull request
Aug 9, 2017
…arty, r=GuillaumeGomez E05XX odyssey chipping away at the surface exposed by #43709 r? @GuillaumeGomez
|
If you are looking for the TcpStream::connect_timeout tracking issue -- it is #43079. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 13, 2017
Fix TcpStream::connect_timeout tracking issue number Before: rust-lang#43709 After: rust-lang#43079 r? @sfackler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bizarrely, librustc_passes, librustc_plugin, librustc_mir, and libsyntax weren't getting their error explanations registered (leaving several error codes absent from the index and
--explain). This surfaced a few latent doctest failures that were fixed where readily possible and ignored (with a recorded excuse) if not.Also, we don't issue E0563 anymore.
r? @GuillaumeGomez