-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E0106: field lifetimes #43912
E0106: field lifetimes #43912
Conversation
I've added an example for custom type lifetimes located in another `struct` fields.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/librustc/diagnostics.rs
Outdated
@@ -362,6 +362,10 @@ Here are some simple examples of where you'll run into this error: | |||
struct Foo { x: &bool } // error | |||
struct Foo<'a> { x: &'a bool } // correct | |||
|
|||
struct Bar{ x: Foo } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put a whitespace before a {
.
src/librustc/diagnostics.rs
Outdated
@@ -362,6 +362,10 @@ Here are some simple examples of where you'll run into this error: | |||
struct Foo { x: &bool } // error | |||
struct Foo<'a> { x: &'a bool } // correct | |||
|
|||
struct Bar{ x: Foo } | |||
^^^ expected lifetime parameter | |||
struct Bar<'a>{ x: Foo<'a> } // correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
Once this fixed, it'll be good. Thanks for your contribution! |
Done! |
Thanks! @bors: r+ rollup |
📌 Commit d6cdefc has been approved by |
…GuillaumeGomez E0106: field lifetimes Hi there, I've added an example for custom type lifetimes located in another `struct` field. cc @GuillaumeGomez
Hi there,
I've added an example for custom type lifetimes located in another
struct
field.cc @GuillaumeGomez