-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #43939
Merged
Merged
Rollup of 9 pull requests #43939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added an example for custom type lifetimes located in another `struct` fields.
As discussed in rust-lang/cargo#4040 (comment) This is a redirect meant to be replaced once cargo docs have been converted to mdbook. We just want *a* URL to ride the trains for now so that we can print doc.rust-lang.org/cargo in the paper book and guarantee that it will go *somewhere* useful by the time the book is printed. Implemented as a meta redirect in HTML because we don't currently have any google juice at doc.rust-lang.org/cargo to lose.
Small cleanup that shouldn't have any impact
Fix typos & us spellings Fixing some typos and non en-US spellings. (Update of PR rust-lang#42812 )
Document that `std::hash::Hasher::finish()` does not reset the hasher. Clarifies the fact that `finish()` doesn’t in fact end or reset the hasher. This was surprising to me … Follows up on and fixes rust-lang#43763
…GuillaumeGomez E0106: field lifetimes Hi there, I've added an example for custom type lifetimes located in another `struct` field. cc @GuillaumeGomez
…isdreavus Update the books for next release
Fix typo in doc
…=alexcrichton Implement a temp redirect for cargo docs As discussed in rust-lang/cargo#4040 (comment) This is a redirect meant to be replaced once cargo docs have been converted to mdbook. We just want *a* URL to ride the trains for now so that we can print doc.rust-lang.org/cargo in the paper book and guarantee that it will go *somewhere* useful by the time the book is printed. Implemented as a meta redirect in HTML because we don't currently have any google juice at doc.rust-lang.org/cargo to lose. When I run `./x.py doc`, this creates a `build/x86_64-apple-darwin/doc/cargo/index.html` file that contains a meta redirect to doc.crates.io. As I understand rust-central-station to work, this should be what we need to make `doc.rust-lang.org/cargo` to work. r? @alexcrichton and/or @steveklabnik
refactor(mir): remove unused argument Small cleanup that shouldn't have any impact, as it's a small thing introduced in rust-lang#43772
…ocfix, r=QuietMisdreavus Fixed typo in RefCell::get_mut "[...] is usually not you want." => "[...] is usually not what you want."
…sxcv Fix ES5 regression with shorthand names. Reverts 1b6c960. I appreciate new features and syntax in Rust, but seriously, don't rewrite anything. Especially if this **breaks** documentation of language itself and every crate hosted at docs.rs.
Some changes occurred in HTML/CSS. |
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=10 |
📌 Commit 235fb23 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 17, 2017
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::hash::Hasher::finish()
does not reset the hasher. #43905, E0106: field lifetimes #43912, Update the books for next release #43914, Fix typo in doc #43915, Implement a temp redirect for cargo docs #43916, refactor(mir): remove unused argument #43920, Fixed typo in RefCell::get_mut #43928, Fix ES5 regression with shorthand names. #43930