stabilize collections_range (closes #30877) #44564
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/liballoc/range.rs
Outdated
| @@ -19,6 +16,7 @@ use Bound::{self, Excluded, Included, Unbounded}; | |||
|
|
|||
| /// `RangeArgument` is implemented by Rust's built-in range types, produced | |||
| /// by range syntax like `..`, `a..`, `..b` or `c..d`. | |||
| #[stable(feature = "collections_range", since = "1.21.0")] | |||
There was a problem hiding this comment.
Unless this is meant to be backport to beta, the since should be 1.22.0
There was a problem hiding this comment.
Woops! Fixed. thanks @kennytm!
budziq
force-pushed
the
stabilize_collections_range
branch
from
2086758 to
381d28f
Compare
There was a problem hiding this comment.
Thanks but from what I can tell, this is not ready to be stabilized yet.
The tracking issue is pretty confusing right now. It would be really helpful if you could look through all the RangeArgument-related work that has happened since the start of the final comment period, and synthesize a detailed summary of where we stand and what people have been asking to change. That includes at least the following threads:
alexcrichton
added
the
S-waiting-on-author
|
I wrote a summary in #30877 (comment). This API is being actively worked on in #44518 so I cancelled the FCP. |
|
Argh sorry! I've procrastinated too long with this one. Thanks for taking this up @dtolnay! |
This is my first PR so excuse me if I have made some mistakes.
I know that similar PR's for stabilizing this feature have been reverted in the past.