Add short error message-format #44636

GuillaumeGomez · 2017-09-16T17:24:55Z

rust-highfive · 2017-09-16T17:24:59Z

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2017-09-16T17:32:25Z

nrc · 2017-09-19T04:38:39Z

Rather than adding a new emitter, could you have the human-readable emitter take an argument for detail level - either short or verbose? It seems that we'd save a lot of code dup (and a macro) that way.

Could you put this behind a feature gate?

GuillaumeGomez · 2017-09-19T07:51:53Z

Yes and yes. I was just thinking that we'd want to fully split both of the features but if not...

GuillaumeGomez · 2017-09-19T21:59:00Z

Ok, now just remain to put it behind a feature flag.

kennytm · 2017-09-20T07:59:38Z

Is it possible to make each error only occupy one line, similar to clang -fno-caret-diagnostics?

Mock up:

$DIR/short-error-format.rs:16:9: error[E0308]: mismatched types
$DIR/short-error-format.rs:18:7: error[E0599]: no method named `salut` found for type `u32` in the current scope
error: aborting due to 2 previous errors

eddyb · 2017-09-20T08:55:21Z

@kenny mismatched types is the worst error in the entire compiler, if you can't see the detail lines. I know it looks pretty but it has screwed over pretty much everyone who doesn't look at the console, including the official RLS extension for VS Code.
I only recently pulled off a hack to have the information available to kate in a manageable way.

kennytm · 2017-09-20T09:05:01Z

@eddyb That sample is referring to the UI test in this PR https://github.com/GuillaumeGomez/rust/blob/a58becd60d7d7a965ed246cf8e290e2bd94043b9/src/test/ui/short-error-format.stderr:

error[E0308]: mismatched types
  --> $DIR/short-error-format.rs:16:9

error[E0599]: no method named `salut` found for type `u32` in the current scope
  --> $DIR/short-error-format.rs:18:7

error: aborting due to 2 previous errors

Improving E0308 could happen independent of this PR.

eddyb · 2017-09-20T09:31:52Z

Oh yeah, in that case, I agree, the example output in #44636 (comment) is a subset of the lines I have from my errfilt conversion, but I also have labels/notes (within some limitations), e.g.:

src/librustc_trans/mir/lvalue.rs:97:62: error[E0308]: mismatched types
src/librustc_trans/mir/lvalue.rs:97:62: expected struct `rustc::ty::layout::FullLayout`, found enum `rustc::mir::tcx::LvalueTy`
src/librustc_trans/mir/lvalue.rs:97:62: note: expected type `rustc::ty::layout::FullLayout<'_>`
src/librustc_trans/mir/lvalue.rs:97:62: found type `rustc::mir::tcx::LvalueTy<'_>`

GuillaumeGomez · 2017-09-20T11:17:11Z

So which output do you want? So I can do it once and for all. :)

estebank · 2017-09-22T20:45:19Z

I feel if the idea is to use as little vertical space the output should be closer to:

$DIR/short-error-format.rs:16:9 - error[E0308]: mismatched types
$DIR/short-error-format.rs:18:7 - error[E0599]: no method named `salut` found for type `u32` in the current scope

error: aborting due to 2 previous errors

Beyond that, I wonder wether it'd be worth it to try to keep in the diagnostic machinery space for custom single line error messages that would work better for short output (and for text editors). May be I'll just go ahead and introduce it for while and see how much of a pain it becomes. If it is too much, we can rip it out. I do feel strongly against improving things for text editors in detriment of cli output.

GuillaumeGomez · 2017-09-24T17:21:29Z

New output available!

estebank

Some nitpicks, but I'm ok with the PR. Leaving it to @nrc / @eddyb to give final r+.

estebank · 2017-09-24T18:27:19Z

src/librustc/session/config.rs


            None => ErrorOutputType::HumanReadable(color),

            Some(arg) => {
                early_error(ErrorOutputType::HumanReadable(color),
-                            &format!("argument for --error-format must be human or json (instead \
-                                      was `{}`)",
+                            &format!("argument for --error-format must be `human` or `json` or \


human, json or short

estebank · 2017-09-24T18:27:40Z

src/librustc/session/mod.rs

@@ -833,9 +841,13 @@ pub fn early_error(output: config::ErrorOutputType, msg: &str) -> ! {
    let emitter: Box<Emitter> = match output {
        config::ErrorOutputType::HumanReadable(color_config) => {
            Box::new(EmitterWriter::stderr(color_config,
-                                           None))
+                                           None,
+                                           false))


Fits in single line?

estebank · 2017-09-24T18:27:58Z

src/librustc/session/mod.rs

@@ -846,9 +858,13 @@ pub fn early_warn(output: config::ErrorOutputType, msg: &str) {
    let emitter: Box<Emitter> = match output {
        config::ErrorOutputType::HumanReadable(color_config) => {
            Box::new(EmitterWriter::stderr(color_config,
-                                           None))
+                                           None,
+                                           false))


Fits in single line?

estebank · 2017-09-24T18:29:14Z

src/librustc/session/mod.rs

        }
        (config::ErrorOutputType::HumanReadable(_), Some(dst)) => {
            Box::new(EmitterWriter::new(dst,
-                                        Some(codemap.clone())))
+                                        Some(codemap.clone()),
+                                        false))


Fits in single line?

GuillaumeGomez · 2017-10-20T15:07:32Z

The branch has been created on rustfmt so I point to it instead.

GuillaumeGomez · 2017-10-21T00:14:13Z

We now have the following error:

[00:00:36] Submodule 'src/tools/rustfmt' (https://github.com/rust-lang-nursery/rustfmt.git) unregistered for path 'src/tools/rustfmt'
[00:00:36] Submodule 'src/tools/rustfmt' (https://github.com/rust-lang-nursery/rustfmt.git) registered for path 'src/tools/rustfmt'
[00:00:37] error: Server does not allow request for unadvertised object fc2c85d423a34086243f019c15e2d9cc2afcbb8f
[00:00:37] Fetched in submodule path 'src/tools/rustfmt', but it did not contain fc2c85d423a34086243f019c15e2d9cc2afcbb8f. Direct fetching of that commit failed.

Anyone has an idea?

topecongiro · 2017-10-21T01:45:13Z

@GuillaumeGomez Could you please use e35e27659dec7a70d1e0e45be2c5f3a02b2c742c? I think I have erased fc2c85d423a34086243f019c15e2d9cc2afcbb8f while I pushed the update :/ I am sorry.

GuillaumeGomez · 2017-10-21T15:02:59Z

Ok, let's hope it'll be the good one this time. :)

GuillaumeGomez · 2017-10-21T15:10:41Z

New error and it doesn't get any better:

[00:02:06] extracting /checkout/obj/build/cache/2017-08-29/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:06] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:02:06]
[00:02:06] Caused by:
[00:02:06] patch for `rustfmt-nightly` in `https://github.com/rust-lang/crates.io-index` did not resolve to any crates
[00:02:06] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:06] Build completed unsuccessfully in 0:00:46

Anyone has an idea?

GuillaumeGomez · 2017-10-24T22:15:15Z

Fixed.

michaelwoerister · 2017-10-25T14:13:52Z

@bors r+

bors · 2017-10-25T14:13:53Z

📌 Commit b46c014 has been approved by michaelwoerister

bors · 2017-10-25T18:19:49Z

⌛ Testing commit b46c014 with merge f9d2416...

…ister Add short error message-format Fixes #42653.

bors · 2017-10-25T22:21:03Z

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing f9d2416 to master...

alexcrichton · 2017-11-14T21:07:32Z

@nrc @GuillaumeGomez this landed without a feature flag, was that intentional? I assume not given #44636 (comment)?

nrc · 2017-11-15T01:25:12Z

I suppose this should be behind -Zunstable-features given that comment. I filed #45995

Thanks for noticing @alexcrichton !

GuillaumeGomez · 2017-11-15T09:27:14Z

Hum indeed, it should had have a feature flag. I'll add it as soon as possible.

vitiral · 2018-02-01T18:32:11Z

❤️ Thanks for fixing the bug I reported, looking forward to using this when it becomes available!

vitiral · 2018-02-01T18:34:46Z

On this comment my preference would be something like:

src/librustc_trans/mir/lvalue.rs:97:62: error[E0308]: mismatched types. Expected struct `rustc::ty::layout::FullLayout`, found enum `rustc::mir::tcx::LvalueTy`

It's all in one line but that's probably okay. That's just, like, my opinion though man.

@oli-obk

…r-format, r=oli-obk Stabilize short error format r? @oli-obk Added in rust-lang#44636

rust-highfive assigned eddyb Sep 16, 2017

rust-highfive assigned nrc and unassigned eddyb Sep 16, 2017

GuillaumeGomez force-pushed the little-error-msg branch from 1b3f2be to 9ad8252 Compare September 17, 2017 10:00

GuillaumeGomez changed the title ~~Add short message-format~~ Add short error message-format Sep 17, 2017

carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2017

GuillaumeGomez force-pushed the little-error-msg branch 6 times, most recently from 8468a5f to a58becd Compare September 19, 2017 21:58

GuillaumeGomez force-pushed the little-error-msg branch 3 times, most recently from d598684 to 30128d6 Compare September 21, 2017 17:47

GuillaumeGomez force-pushed the little-error-msg branch from 30128d6 to bec51da Compare September 24, 2017 14:40

estebank approved these changes Sep 24, 2017

View reviewed changes

GuillaumeGomez force-pushed the little-error-msg branch from bec51da to a4b28f2 Compare September 24, 2017 19:28

GuillaumeGomez force-pushed the little-error-msg branch from fff79bd to 3f68f78 Compare October 21, 2017 15:02

estebank mentioned this pull request Oct 24, 2017

Detect = -> : typo in let bindings #45452

Merged

Set rustfmt broken while waiting for the update of their side

b46c014

GuillaumeGomez force-pushed the little-error-msg branch from 3f68f78 to b46c014 Compare October 24, 2017 18:44

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2017

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2017

bors added a commit that referenced this pull request Oct 25, 2017

Auto merge of #44636 - GuillaumeGomez:little-error-msg, r=michaelwoer…

f9d2416

…ister Add short error message-format Fixes #42653.

bors merged commit b46c014 into rust-lang:master Oct 25, 2017

GuillaumeGomez deleted the little-error-msg branch October 26, 2017 08:30

QuietMisdreavus mentioned this pull request Nov 13, 2017

add support for rustc's --error-format short rust-lang/cargo#4720

Closed

estebank mentioned this pull request Nov 14, 2017

Highlight code on diagnostics when underlined #45776

Closed

GuillaumeGomez mentioned this pull request Apr 2, 2018

Stabilize short error format #49546

Merged

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 31, 2018

Rollup merge of rust-lang#49546 - GuillaumeGomez:stabilize-short-erro…

0345dac

…r-format, r=oli-obk Stabilize short error format r? @oli-obk Added in rust-lang#44636

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add short error message-format #44636

Add short error message-format #44636

GuillaumeGomez commented Sep 16, 2017

rust-highfive commented Sep 16, 2017

eddyb commented Sep 16, 2017

nrc commented Sep 19, 2017

GuillaumeGomez commented Sep 19, 2017

GuillaumeGomez commented Sep 19, 2017

kennytm commented Sep 20, 2017

eddyb commented Sep 20, 2017

kennytm commented Sep 20, 2017 •

edited

Loading

eddyb commented Sep 20, 2017 •

edited

Loading

GuillaumeGomez commented Sep 20, 2017

estebank commented Sep 22, 2017

GuillaumeGomez commented Sep 24, 2017

estebank left a comment

estebank Sep 24, 2017

estebank Sep 24, 2017

estebank Sep 24, 2017

estebank Sep 24, 2017

GuillaumeGomez commented Oct 20, 2017

GuillaumeGomez commented Oct 21, 2017

topecongiro commented Oct 21, 2017

GuillaumeGomez commented Oct 21, 2017

GuillaumeGomez commented Oct 21, 2017

GuillaumeGomez commented Oct 24, 2017

michaelwoerister commented Oct 25, 2017

bors commented Oct 25, 2017

bors commented Oct 25, 2017

bors commented Oct 25, 2017

alexcrichton commented Nov 14, 2017

nrc commented Nov 15, 2017

GuillaumeGomez commented Nov 15, 2017

vitiral commented Feb 1, 2018

vitiral commented Feb 1, 2018

Add short error message-format #44636

Add short error message-format #44636

Conversation

GuillaumeGomez commented Sep 16, 2017

rust-highfive commented Sep 16, 2017

eddyb commented Sep 16, 2017

nrc commented Sep 19, 2017

GuillaumeGomez commented Sep 19, 2017

GuillaumeGomez commented Sep 19, 2017

kennytm commented Sep 20, 2017

eddyb commented Sep 20, 2017

kennytm commented Sep 20, 2017 • edited Loading

eddyb commented Sep 20, 2017 • edited Loading

GuillaumeGomez commented Sep 20, 2017

estebank commented Sep 22, 2017

GuillaumeGomez commented Sep 24, 2017

estebank left a comment

Choose a reason for hiding this comment

estebank Sep 24, 2017

Choose a reason for hiding this comment

estebank Sep 24, 2017

Choose a reason for hiding this comment

estebank Sep 24, 2017

Choose a reason for hiding this comment

estebank Sep 24, 2017

Choose a reason for hiding this comment

GuillaumeGomez commented Oct 20, 2017

GuillaumeGomez commented Oct 21, 2017

topecongiro commented Oct 21, 2017

GuillaumeGomez commented Oct 21, 2017

GuillaumeGomez commented Oct 21, 2017

GuillaumeGomez commented Oct 24, 2017

michaelwoerister commented Oct 25, 2017

bors commented Oct 25, 2017

bors commented Oct 25, 2017

bors commented Oct 25, 2017

alexcrichton commented Nov 14, 2017

nrc commented Nov 15, 2017

GuillaumeGomez commented Nov 15, 2017

vitiral commented Feb 1, 2018

vitiral commented Feb 1, 2018

kennytm commented Sep 20, 2017 •

edited

Loading

eddyb commented Sep 20, 2017 •

edited

Loading