Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to headers in README and CONTRIBUTING #44935

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

vitiral
Copy link
Contributor

@vitiral vitiral commented Sep 29, 2017

this also adds dependencies to CONTRIBUTING

I'm just getting started building the rust compiler and noticed this information/ability was missing.

It was also missing the gdb dependency for running tests. I pulled the information out of appveyor.yml and recommended later than 7.1 because that is what apt ships. Feel free to tell me something different!

@carols10cents
Copy link
Member

Hi! Welcome, and thanks for your contribution! We'll be checking in to make sure this gets reviewed by the appropriate folks.

r? @steveklabnik

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2017
@steveklabnik
Copy link
Member

Hi! Sorry that this took so long to review; I was traveling. This looks good to me! Thank you!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Oct 5, 2017

📌 Commit daf3ed5 has been approved by steveklabnik

kennytm added a commit to kennytm/rust that referenced this pull request Oct 5, 2017
Add links to headers in README and CONTRIBUTING

this also adds dependencies to CONTRIBUTING

I'm just getting started building the rust compiler and noticed this information/ability was missing.

It was also missing the gdb dependency for running tests. I pulled the information out of `appveyor.yml` and recommended later than 7.1 because that is what [apt ships](https://packages.ubuntu.com/search?suite=trusty&keywords=gdb). Feel free to tell me something different!
bors added a commit that referenced this pull request Oct 5, 2017
Rollup of 9 pull requests

- Successful merges: #44664, #44935, #44972, #44980, #44987, #44997, #45006, #45017, #45024
- Failed merges:
@bors bors merged commit daf3ed5 into rust-lang:master Oct 5, 2017
@vitiral
Copy link
Contributor Author

vitiral commented Oct 13, 2017

@steveklabnik realized I never responded. No problem and thanks!

@vitiral vitiral deleted the dependencies branch October 27, 2017 05:59
@ehuss ehuss mentioned this pull request Jul 9, 2019
bors added a commit that referenced this pull request Jul 11, 2019
Update cargo-vendor usage

This contains a variety of updates to clean up the usage of cargo-vendor.

- Remove the install step for the old cargo-vendor now that it is built-in to cargo and available in the stage0 install.
- Update installation instructions, dealing with vendoring. The current instructions of running `sudo ./x.py install` is broken, it will almost always fail (since the vendor directory doesn't exist). Since the steps for properly handling this are numerous, I'm recommending removing the suggestion to use `sudo` altogether.
- If the sudo-forced-vendoring detects that the vendor directory is not available, abort with instructions on how to fix.
- Now that cargo-vendor is built-in, automatically run it if it looks like it is needed.
- Update instructions on how to install cargo.
- Remove the unused markdown link references in README/CONTRIBUTING. This reverts most of #44935. These references don't do anything if they are unused.

Closes #49269
cc #61142 #48771 #40108
bors added a commit that referenced this pull request Jul 12, 2019
Update cargo-vendor usage

This contains a variety of updates to clean up the usage of cargo-vendor.

- Remove the install step for the old cargo-vendor now that it is built-in to cargo and available in the stage0 install.
- Update installation instructions, dealing with vendoring. The current instructions of running `sudo ./x.py install` is broken, it will almost always fail (since the vendor directory doesn't exist). Since the steps for properly handling this are numerous, I'm recommending removing the suggestion to use `sudo` altogether.
- If the sudo-forced-vendoring detects that the vendor directory is not available, abort with instructions on how to fix.
- Now that cargo-vendor is built-in, automatically run it if it looks like it is needed.
- Update instructions on how to install cargo.
- Remove the unused markdown link references in README/CONTRIBUTING. This reverts most of #44935. These references don't do anything if they are unused.

Closes #49269
cc #61142 #48771 #40108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants