Rollup of 9 pull requests #45046
Merged
Rollup of 9 pull requests #45046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade comment to doc comment.
Also fixes some stdlib links to the reference which have changed.
some dataflow-tracked borrow-data entry. Fix rust-lang#44828 (The comment thread on the aforementioned issue discusses why its best to just remove this assertion.)
…veklabnik Corrected the CONTRIBUTING.md "External Dependencies" section The "External Dependencies" section is a little outdated. Please see following comments rust-lang#44567 (comment) rust-lang#44567 (comment) for rationale.
Add links to headers in README and CONTRIBUTING this also adds dependencies to CONTRIBUTING I'm just getting started building the rust compiler and noticed this information/ability was missing. It was also missing the gdb dependency for running tests. I pulled the information out of `appveyor.yml` and recommended later than 7.1 because that is what [apt ships](https://packages.ubuntu.com/search?suite=trusty&keywords=gdb). Feel free to tell me something different!
fix ItemKind::DefaultImpl doc comment Upgrade comment to doc comment. ...Is this actually used? If so, why does the `Impl` variant right below have a `Defaultness`?
update books for next release Also fixes some stdlib links to the reference which have changed. First step in https://forge.rust-lang.org/release-process.html, doing it a few days early 😄
…exes-ice, r=arielb1 `EndRegion` do not always correspond to borrow-data entries Remove assertion that the argument to every `EndRegion` correspond to some dataflow-tracked borrow-data entry. Fix rust-lang#44828 (The comment thread on the aforementioned issue discusses why its best to just remove this assertion.)
Use HTTPS protocol for "chat.mibbit.com" I changed the `http://` protocol to `https://` for the `chat.mibbit.com` website. 📝 --[**Suriyaa**](https://mozillians.org/de/u/suriyaakudo/) 🦊 (*PS: Is somebody interested to vouch me at https://mozillians.org/de/u/suriyaakudo/?*)
Typo in `librustc/README.md`
Add missing urls for Mutex r? @rust-lang/docs
…m, r=pnkfelix add the issue number to doc_masked's feature gate Whoops, missed this in the original `#[doc(masked)]` PR.
|
@bors r+ p=9 |
|
📌 Commit 5440733 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 5, 2017
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EndRegiondo not always correspond to borrow-data entries #44987, Use HTTPS protocol for "chat.mibbit.com" #44997, Typo inlibrustc/README.md#45006, Add missing urls for Mutex #45017, add the issue number to doc_masked's feature gate #45024