make coercions to ! in unreachable code a hard error
#45880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
S-waiting-on-crater
|
@bors try |
|
⌛ Trying commit 2dd1dbfc3041345ba17a9d372412f01eb13a0d32 with merge 371771a40e0262d2b480f622def0e79a1e4b378c... |
|
☀️ Test successful - status-travis |
|
Crater started. |
|
Nice. |
|
r? @eddyb (just making sure this has an assigned reviewer) |
|
LGTM, if we actually want to do this, I guess. |
|
Please rebase onto master and run another try build to pick up fixes in Cargo. |
kennytm
added
S-waiting-on-author
arielb1
force-pushed
the
never-coerce
branch
from
2dd1dbf
to
491d128
Compare
|
Force push done. Waiting for another crater run. |
|
@bors try |
bors
added a commit
that referenced
this pull request
Nov 15, 2017
[needs crater] make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in #35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
kennytm
added
S-waiting-on-crater
|
☀️ Test successful - status-travis |
|
Crater run started |
|
Hi @arielb1 (crater requester), @eddyb (reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-45580/index.html. 'Blacklisted' crates (spurious failures etc) can be found |
|
All failures look spurious. |
|
I suppose we'll merge this with deny-by-default, given that there were no failures on crater |
arielb1
changed the title
! in unreachable code a hard error! in unreachable code a hard error
kennytm
added
the
S-waiting-on-review
kennytm
removed
the
S-waiting-on-review
mzji
reviewed
Nov 30, 2017
src/librustc_lint/lib.rs
Outdated
| @@ -247,6 +247,10 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) { | |||
| id: LintId::of(SAFE_PACKED_BORROWS), | |||
| reference: "issue #46043 <https://github.com/rust-lang/rust/issues/46043>", | |||
| }, | |||
| FutureIncompatibleInfo { | |||
| id: LintId::of(COERCE_NEVER), | |||
| reference: "issue #46325 <https://github.com/rust-lang/rust/issues/42869>", | |||
There was a problem hiding this comment.
This link should be fixed (point to an issue related to never type coercion).
mzji
reviewed
Nov 30, 2017
| 15 | #![deny(coerce_never)] | ||
| | ^^^^^^^^^^^^ | ||
| = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
| = note: for more information, see issue #46325 <https://github.com/rust-lang/rust/issues/42869> |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
arielb1
force-pushed
the
never-coerce
branch
from
235de09
to
5a00b7c
Compare
|
@bors r=nikomatsakis rollup |
|
📌 Commit 5a00b7c has been approved by |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 1, 2017
make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to cover up a lazy extra semicolon in #35849, but does
not actually make sense. This is removed as a part of the stabilization
of
never_type.