-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #46404
Closed
Closed
Rollup of 10 pull requests #46404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...that were removed in 77c3bfa.
The documentation states: "The name output should be the name of the library." and this is already done in more recently-added callers.
This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=12 |
📌 Commit c2b48c1 has been approved by |
kennytm
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Nov 30, 2017
⌛ Testing commit c2b48c1 with merge 06490d1c61b7e4f1239eeafaa878835e2f67f132... |
💔 Test failed - status-travis |
make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
rustc_llvm: remove stale references ...that were removed in 77c3bfa. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!
in unreachable code a hard error #45880, rustc_llvm: remove stale references #46280, Update compiler-builtins and use it in the 128-bit lowering MIR test #46290, Fix hygiene bug. #46343, On type mismatch error highlight&
when type matches #46349, incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. #46368, rustdoc: Fix issues with cross-crate inlined associated items #46384, rustbuild: Fix a typo with the Cargo book #46385, Remove librustdoc dependency on env_logger #46386, incr.comp.: Make traits::VTable encodable and decodable. #46400