incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. #46368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ans for type definitions.
kennytm
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 89dc8ae has been approved by |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…uginfo-spans, r=eddyb incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. r? @nikomatsakis
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…uginfo-spans, r=eddyb incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. r? @nikomatsakis
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…uginfo-spans, r=eddyb incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. r? @nikomatsakis
kennytm
added
S-waiting-on-bors
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…uginfo-spans, r=eddyb incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Dec 2, 2017
…s, r=eddyb incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
|
This appears to have regressed performance on perf.rlo (http://perf.rust-lang.org/compare.html?start=9053fdd411e81910a86b68f0a1c3b3ca084bff62&end=377decc352e58aa2bb0e2deb2eb66c3e7241a622&stat=wall-time): was that expected? |
|
Thanks for the heads up, @Mark-Simulacrum. It's not entirely surprising, since we are hashing more and we detect more changes. Most of these newly detected changes are probably false positives of some kind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis