Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize spin_loop_hint #46174

Merged
merged 3 commits into from Nov 28, 2017
Merged

Stabilize spin_loop_hint #46174

merged 3 commits into from Nov 28, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2017

Stabilize spin_loop_hint in release 1.23.0.
I've also renamed feature hint_core_should_pause to spin_loop_hint.

cc #41196

@rust-highfive
Copy link
Collaborator

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv frewsxcv assigned sfackler and unassigned frewsxcv Nov 22, 2017
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 22, 2017
@carols10cents
Copy link
Member

Review ping for you @sfackler !

@sfackler
Copy link
Member

@alexcrichton Do you want to backport this to 1.23 or push it out to 1.24?

@alexcrichton
Copy link
Member

Nah I'm personally ok leaving it with 1.24

@alexcrichton alexcrichton reopened this Nov 27, 2017
@alexcrichton
Copy link
Member

egad didn't mean to close...

@sfackler
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 27, 2017

📌 Commit d5e8b61 has been approved by sfackler

kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2017
@kennytm
Rollup merge of rust-lang#46174 - stjepang:stabilize-spinloophint, r=…
aa99bd9 
…sfackler

Stabilize spin_loop_hint

Stabilize `spin_loop_hint` in release `1.23.0`.
I've also renamed feature `hint_core_should_pause` to `spin_loop_hint`.

cc rust-lang#41196
@kennytm kennytm mentioned this pull request Nov 27, 2017
Merged
bors added a commit that referenced this pull request Nov 27, 2017
@bors
Auto merge of #46312 - kennytm:rollup, r=kennytm
b087a99 
Rollup of 10 pull requests

- Successful merges: #45506, #46174, #46231, #46240, #46249, #46258, #46262, #46275, #46282, #46285
- Failed merges:
@Mark-Simulacrum
Copy link
Member

@bors rollup

@bors bors merged commit d5e8b61 into rust-lang:master Nov 28, 2017
@ghost ghost deleted the stabilize-spinloophint branch January 11, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rust-highfive @carols10cents @sfackler @alexcrichton @bors @Mark-Simulacrum @kennytm @frewsxcv