Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document non-obvious behavior of fmt::UpperHex & co for negative integers #46285

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Document non-obvious behavior of fmt::UpperHex & co for negative integers #46285

merged 1 commit into from
Nov 28, 2017

Conversation

SimonSapin
Copy link
Contributor

Before stabilization I’d have suggested changing the behavior, but that time is past.

@SimonSapin
Document non-obvious behavior of fmt::UpperHex & co for negative inte…
a326d8d 
…gers

Before stabilization I’d have suggested changing the behavior,
but that time is past.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SimonSapin
Copy link
Contributor Author

Maybe these doc-comments should be on respective impls instead?

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Nov 27, 2017
@kennytm
Copy link
Member

kennytm commented Nov 27, 2017

Reassigning to docs team — r? @GuillaumeGomez

@SimonSapin SimonSapin mentioned this pull request Nov 27, 2017
Closed
@GuillaumeGomez
Copy link
Member

Sounds good. Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Nov 27, 2017

📌 Commit a326d8d has been approved by GuillaumeGomez

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2017
@kennytm
Rollup merge of rust-lang#46285 - SimonSapin:twos-complement, r=Guill…
83a6f38 
…aumeGomez

Document non-obvious behavior of fmt::UpperHex & co for negative integers

Before stabilization I’d have suggested changing the behavior,  but that time is past.
@kennytm kennytm mentioned this pull request Nov 27, 2017
Merged
bors added a commit that referenced this pull request Nov 27, 2017
@bors
Auto merge of #46312 - kennytm:rollup, r=kennytm
b087a99 
Rollup of 10 pull requests

- Successful merges: #45506, #46174, #46231, #46240, #46249, #46258, #46262, #46275, #46282, #46285
- Failed merges:
@bors bors merged commit a326d8d into rust-lang:master Nov 28, 2017
@SimonSapin SimonSapin deleted the twos-complement branch November 28, 2017 07:35
@Phlosioneer Phlosioneer mentioned this pull request Mar 11, 2018
Closed
@cmcqueen
Copy link

Before stabilization I’d have suggested changing the behavior, but that time is past.

Is there any chance this can be changed in a Rust edition? Eg the upcoming 2021 edition.

@kennytm
Copy link
Member

kennytm commented Jun 23, 2021

No, the runtime behavior is edition-agnostic in the since they share the same libcore. That means we either change it for all of 2015/2018/2021 starting from Rust 1.XX or never change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SimonSapin @rust-highfive @kennytm @GuillaumeGomez @bors @cmcqueen @alexcrichton